Murano metadata repository returns 500 status code on request to switch service parameter enabled/disabled for nonexistent service

Bug #1268976 reported by Sergey Murashov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Ekaterina Chernova

Bug Description

Steps to reproduce:
1. Install murano from 0.4 branch
2. Send POST <metadata repository url>/v1/admin/services/<name of nonexistent service>/toggle_enabled

Actual result:
Murano metadata repository return 500 status code

Expected result:
Murano metadata repository return 404 status code

Tags: verified
Changed in murano:
assignee: nobody → Timur Sufiev (tsufiev-x)
importance: Undecided → Medium
milestone: none → 0.4.1
Changed in murano:
status: New → Invalid
status: Invalid → New
Changed in murano:
status: New → Confirmed
assignee: Timur Sufiev (tsufiev-x) → Ekaterina Fedorova (efedorova)
status: Confirmed → In Progress
summary: - Murano metadata repository return 500 status code on request to switch
+ Murano metadata repository returns 500 status code on request to switch
service parameter enabled/disabled for nonexistent service
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-repository (master)

Reviewed: https://review.openstack.org/66825
Committed: https://git.openstack.org/cgit/stackforge/murano-repository/commit/?id=32a54a05904bdb69012be1da0dc13a62d6d5471e
Submitter: Jenkins
Branch: master

commit 32a54a05904bdb69012be1da0dc13a62d6d5471e
Author: Ekaterina Fedorova <email address hidden>
Date: Wed Jan 15 16:39:54 2014 +0400

    Return correct http code

    During toggle enabled 500 was sent in case service is not defined
    Fix return code to 404
    Closes-Bug: #1268976
    Change-Id: I726d8b8849b2ccd44fdbf9d7b4ce65f3a62cf4fc

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-repository (release-0.4)

Reviewed: https://review.openstack.org/67429
Committed: https://git.openstack.org/cgit/stackforge/murano-repository/commit/?id=72337dc3ac680402713ec95d48c5a6aa35b59bad
Submitter: Jenkins
Branch: release-0.4

commit 72337dc3ac680402713ec95d48c5a6aa35b59bad
Author: Ekaterina Fedorova <email address hidden>
Date: Fri Jan 10 16:54:30 2014 +0400

    Update from master with following commits

    * Fix log.exception usage. Add log translating
      Closes-bug: #1264980

    * Add per-tenant isolation
      Implements blueprint per-tenant-isolation

    * Fixed issue with Key Pairs for Linux-based services
      Implements: blueprint rewrite-key-pair-for-linux-based-services
    * Add service_definition directory existence checkup
      Closes-Bug: #1269431

    * Make some refactoring

    * Add forgotten return
      Closes-Bug: #1249303

    * Add forgotten return statements
      Closes-Bug: #1268934

    * Fix error code when there is no input json

    * Return correct http code
      Closes-Bug: #1268976

    Change-Id: I726d8b8849b2ccd44fdbf9d7b4ce65f3a62cf4aa

tags: added: verified
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-repository (master)

Fix proposed to branch: master
Review: https://review.openstack.org/72607

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-repository (master)

Reviewed: https://review.openstack.org/72607
Committed: https://git.openstack.org/cgit/stackforge/murano-repository/commit/?id=d353dacf8eace1525b0fe623b39d2a230558541d
Submitter: Jenkins
Branch: master

commit d353dacf8eace1525b0fe623b39d2a230558541d
Author: Ekaterina Fedorova <email address hidden>
Date: Tue Jan 14 16:40:00 2014 +0400

    Cherry-pick the following commits from release-0.4

    * Add forgotten return statements
     Closes-bug: #1268934

    * Fix error code when there is no input json

    * Return correct http code

     During toggle enabled 500 was sent in case service is not defined
     Fix return code to 404
     Closes-Bug: #1268976

    * Remove need to specify IP for load balancer
     Implements:
        https://blueprints.launchpad.net/murano/+spec/auto-assign-virtual-ip
     Address blueprint auto-assign-virtual-ip
     Fix errors in infrastructure
     1) Update path to config file
     2) Update sample config - remove non-existing directory
     3) Add 0.4.1 version
     Fixes-Bug: 1270734

    * Add new setup and SysV scripts

    * Removed SysV EL6 standalone file, removed old setup scripts

    * Add correct error message when no config specified
     Closes-Bug: 1271092

    * Security rules updated
     * incorrect port ranges for ADDS fixed according to
     http://technet.microsoft.com/en-us/library/dd772723%28v=WS.10%29.aspx
     * security template for Windows Server Failover Cluster added according to
     http://support.microsoft.com/kb/832017#method5
     * security rules for SQL Server updated according to
     http://technet.microsoft.com/en-us/library/cc646023.aspx

     Relates-Bug: 1264088

    * Typo fixed

    * Revert change
     This reverts commit d87bc2309fcc4cc71aaa3d2512e9bcdc6f39b8c0.

    * Path flattening is reverted, but opening ports for WinRM 2.0 is kept.
     Related-Bug: #1271578

    * Fix paths to scripts used by MS SQL Cluster templates.
     Partial-Bug: #1271578

    * Fix returning list of files in nested dirs - don't cut first symbol.

    * And fix a minor PyCharm warning about var not being initialized.
     Closes-Bug: #1274851

    * Add checkbox to enable floating IP auto assignment

    * Implements blueprint auto-assign-floating-ip

    * Fixed typo in conductor workflow
     Closes-Bug: 1264250

    * Add service version during service creation
     Closes-Bug: 1269360

    * Resolve issue with KeyPair assignment
     nvironment with a service with Key Pair assigned
     could not be deployed due to invalid match in workflows
     causing invalid Heat template to be produced by Conductor.
     Closes-bug: #1274011

    * Correct inform message during floating ip creation

    * Fix name for syslog_log_facility param

    Change-Id: Id3ad4581cd9ce40a569ac580d0aee8db017855c4

Changed in murano:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.