preview doesn't work

Bug #126459 reported by Aaron Swartz
2
Affects Status Importance Assigned to Milestone
Open Library
Fix Released
Medium
Anand Chitipothu

Bug Description

Aaron Swartz (aaronsw)
Changed in openlibrary:
assignee: nobody → anandology
importance: Undecided → Medium
milestone: none → launch
status: New → Confirmed
Revision history for this message
Anand Chitipothu (anandology) wrote :

As of now, every type handles its own preview. Which, I think should be handled by the system.

Probably the view template can be used to display preview, but without those edit, history etc. links.

How about something like this:

* view template just displays the page and doesn't worry about adding edit, history etc links, which will be taken care by a view wrapper template.
* edit template just takes care of providing edit form and doesn't worry about preview.
* edit wrapper supports preview using the view template.

Revision history for this message
Anand Chitipothu (anandology) wrote :

fixed on staging.

Now there are 2 new templates viewpage and editpage, which adds the required header and footer.
render.view and render.edit are available in templates as thingview and thingedit.
editpage supports preview by calling thingview.

Shall we also add support to see diff between the latest version and version being edited?

Changed in openlibrary:
status: Confirmed → Fix Committed
Revision history for this message
Aaron Swartz (aaronsw) wrote : Re: [Bug 126459] Re: preview doesn't work

> Shall we also add support to see diff between the latest version and
> version being edited?

That would be cool.

Revision history for this message
webchick (webchick) wrote :

Anand says this has been fixed - there may be some issues. We need to turn it off on some templates, like i18n.

Changed in openlibrary:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.