OpenStack Identity (keystone)

Change attribute_ignore from string to list

Bug #1259735 reported by Craig Jellick
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
Wu Wenxiang
OpenStack Identity (keystone) 2014.1 "icehouse"

Bug Description

In keystone/common/ldap/core.py,
when self.attribute_ignore is loaded from the config, it is loaded as a string, not a list. This causes all the
  if...k in self.attribute_ignore:
checks to not behave as expected.

For example, if user_attribute_ignore looks like this:
user_attribute_ignore=project_id,foo_bar
then attributes named project, id, foo, and bar would all be ignored because they are all in that string

Dolph Mathews (dolph)
Changed in keystone:
importance: Undecided → Medium
Wu Wenxiang (wu-wenxiang)
Changed in keystone:
assignee: nobody → Wu Wenxiang (wu-wenxiang)
Revision history for this message
Wu Wenxiang (wu-wenxiang) wrote :

Ref to https://bugs.launchpad.net/oslo/+bug/1261792

1. Here we just need to modify the default value in codes.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/62698

Changed in keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/62698
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=309976fe23417d0f0fcf22c381ae0d9d6df74fb9
Submitter: Jenkins
Branch: master

commit 309976fe23417d0f0fcf22c381ae0d9d6df74fb9
Author: Wu Wenxiang <wu.wenxiang@99cloud.net>
Date: Tue Dec 17 23:45:47 2013 +0800

    Change ListOpt default value from str or None to list

    In keystone/common/config.py, some ListOpt config object was inited
    with a string or None default value, it's incorrect. This patch modifies
    their default value to list objects.

    Change-Id: I2aec4f49d94e131d45f7dc9bfeb63b8d819d0bb1
    Closes-Bug: #1259735

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.