The objects that are shared with all other ones and that just provide methods should be singletons
Bug #1259158 reported by
Manuel de la Peña
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
Medium
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In order to use less memory and make the track of memory used the shared objects should be singletons so that that code is cleaner.
Related branches
lp://staging/~mandel/ubuntu-download-manager/singletons
- Diego Sarmentero (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 2233 lines (+373/-392)37 files modifiedlibubuntudownloadmanager/downloads/download.cpp (+8/-9)
libubuntudownloadmanager/downloads/download.h (+1/-5)
libubuntudownloadmanager/downloads/downloads_db.cpp (+7/-22)
libubuntudownloadmanager/downloads/downloads_db.h (+0/-1)
libubuntudownloadmanager/downloads/factory.cpp (+8/-17)
libubuntudownloadmanager/downloads/factory.h (+0/-6)
libubuntudownloadmanager/downloads/file_download.cpp (+11/-21)
libubuntudownloadmanager/downloads/file_download.h (+0/-7)
libubuntudownloadmanager/downloads/group_download.cpp (+2/-28)
libubuntudownloadmanager/downloads/group_download.h (+2/-18)
libubuntudownloadmanager/downloads/manager.cpp (+3/-9)
libubuntudownloadmanager/downloads/manager.h (+0/-4)
libubuntudownloadmanager/downloads/queue.cpp (+5/-5)
libubuntudownloadmanager/downloads/queue.h (+1/-4)
libubuntudownloadmanager/system/file_manager.cpp (+28/-0)
libubuntudownloadmanager/system/file_manager.h (+16/-2)
libubuntudownloadmanager/system/process_factory.cpp (+31/-0)
libubuntudownloadmanager/system/process_factory.h (+14/-1)
libubuntudownloadmanager/system/request_factory.cpp (+37/-0)
libubuntudownloadmanager/system/request_factory.h (+17/-2)
libubuntudownloadmanager/system/system_network_info.cpp (+31/-0)
libubuntudownloadmanager/system/system_network_info.h (+17/-2)
ubuntu-download-manager-tests/downloads/test_download.cpp (+58/-110)
ubuntu-download-manager-tests/downloads/test_download_factory.cpp (+2/-2)
ubuntu-download-manager-tests/downloads/test_download_factory.h (+0/-1)
ubuntu-download-manager-tests/downloads/test_download_manager.cpp (+17/-21)
ubuntu-download-manager-tests/downloads/test_download_queue.cpp (+3/-7)
ubuntu-download-manager-tests/downloads/test_download_queue.h (+0/-1)
ubuntu-download-manager-tests/downloads/test_downloads_db.cpp (+3/-8)
ubuntu-download-manager-tests/downloads/test_group_download.cpp (+38/-37)
ubuntu-download-manager-tests/downloads/test_group_download.h (+1/-2)
ubuntu-download-manager-tests/fakes/fake_download.cpp (+2/-8)
ubuntu-download-manager-tests/fakes/fake_download.h (+0/-6)
ubuntu-download-manager-tests/fakes/fake_download_factory.cpp (+7/-15)
ubuntu-download-manager-tests/fakes/fake_download_factory.h (+0/-6)
ubuntu-download-manager-tests/fakes/fake_download_queue.cpp (+2/-3)
ubuntu-download-manager-tests/fakes/fake_download_queue.h (+1/-2)
Changed in ubuntu-download-manager: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision 206, scheduled for release in ubuntu- download- manager, milestone 0.3