NeutronCommand requires subclass unnecessary log = logging.getLogger lines
Bug #1258028 reported by
Isaku Yamahata
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-neutronclient |
Fix Released
|
Low
|
Isaku Yamahata |
Bug Description
It is a common pattern to add
class XXXCommand(
log = logging.
But the logger name can be determined automatically, so it caused unnecessary code template.
They can be eliminated
Changed in python-neutronclient: | |
assignee: | nobody → Isaku Yamahata (yamahata) |
status: | New → In Progress |
Changed in python-neutronclient: | |
importance: | Undecided → Medium |
importance: | Medium → Low |
Changed in python-neutronclient: | |
milestone: | none → 2.3.7 |
Changed in python-neutronclient: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/59310 /git.openstack. org/cgit/ openstack/ python- neutronclient/ commit/ ?id=4164de2bdb4 8eaacc58a70790a adb21b78cbf723
Committed: https:/
Submitter: Jenkins
Branch: master
commit 4164de2bdb48eaa cc58a70790aadb2 1b78cbf723
Author: Isaku Yamahata <email address hidden>
Date: Tue Nov 26 16:01:29 2013 +0900
setup logger name of NeutronCommand automatically
It is a common pattern to add NeutronCommand) : getLogger( __name_ _ + '.<command name>').
class XXXCommand(
log = logging.
So introduce a metaclass to do that automatically in order to simplify
the code a bit.
Closes-Bug: #1258028 4d9e57360f6ba22 e153d0d35bd
Change-Id: I7908e3e2c0f3f0