Scratch

Unable to access HeaderBar in fullscreen [$15]

Bug #1256739 reported by Danielle Foré
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Maya
Fix Released
Medium
Unassigned
Maya 0.3 "Sandy Cheeks"
Noise
Fix Released
Undecided
Unassigned
Scratch
Fix Released
High
Viko Adi Rahmawan
Scratch 2.1

Bug Description

The Fullscreen button hides the HeaderBar for some reason.

Related branches

lp://staging/~vikoadi/scratch/fullscreen-toolbar
Danielle Foré: Needs Fixing
Robert Roth (community): Approve (code review)
Diff: 153 lines (+20/-14)
8 files modified
plugins/folder-manager/FolderManagerPlugin.vala (+2/-1)
plugins/pastebin/pastebin.vala (+2/-1)
plugins/pastebin/pastebin_dialog.vala (+3/-1)
src/Dialogs/PreferencesDialog.vala (+4/-2)
src/MainWindow.vala (+5/-4)
src/Services/Document.vala (+1/-1)
src/Utils.vala (+2/-2)
src/scratch-ui.xml (+1/-2)
lp://staging/~codygarver/scratch/scratch-drop-fullscreen
Danielle Foré: Approve
Diff: 58 lines (+0/-21)
1 file modified
src/MainWindow.vala (+0/-21)
Danielle Foré (danrabbit)
Changed in scratch:
milestone: none → isis-beta1
Mario Guerriero (mefrio-g)
Changed in scratch:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Cameron Norman (cameronnemo) wrote :

I think this is a problem at the window manager level, because when I use the fullscreen window shortcut (I have it configured to alt + f, do not know the default), it dissappears in Maya and Noise.

Changed in maya:
status: New → Confirmed
Revision history for this message
Cameron Norman (cameronnemo) wrote :

Also, since you can fullscreen a window with a WM shortcut, removing the in app keyboard shortcut and menu option (like with Noise) is not that great a solution.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Shortcuts aren't really an issue since we can assume of someone knows the shortcut they'll be able to get out of fullscreen. The concern is more for people that don't know about the keyboard shortcuts.

Cody Garver (codygarver)
Changed in scratch:
importance: Low → Medium
Changed in maya:
importance: Undecided → Medium
milestone: none → isis-beta1
Revision history for this message
Danielle Foré (danrabbit) wrote :

The Maya I see here doesn't have fullscreen in the menu so marking as fixed for Maya

Changed in maya:
status: Confirmed → Fix Committed
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Bumping priority to High because this bug can completely lock the system for anyone who doesn't remember the keyboard shortcuts.

Changed in scratch:
importance: Medium → High
Revision history for this message
Jacob Parker (jacobparker1992) wrote :

Would it make sense to remove this fullscreen feature entirely? With the headerbar, the space is saved anyway, and having it only adds clutter to the gear menu.

Revision history for this message
Jacob Parker (jacobparker1992) wrote :

I'll also add, if somebody accidentally clicks it, they'll have no idea how to recover. It just seems like a hindrance over anything.

Sergey "Shnatsel" Davidoff (shnatsel)
Changed in noise:
status: New → Incomplete
Danielle Foré (danrabbit)
Changed in noise:
status: Incomplete → Fix Committed
milestone: none → isis-beta2
milestone: isis-beta2 → none
status: Fix Committed → Fix Released
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

There's no Fullscreen button in the current Isis version of Noise and F11 does nothing. Marking incomplete for Noise.

Revision history for this message
Jacob Parker (jacobparker1992) wrote :

Sorry, that's my bad. I remembered it was like that a few weeks ago. I'll add, Scratch will then be the only elementary application to have this feature.

Revision history for this message
Robert Roth (evfool) wrote :

gEdit solves this by replicating the toolbar in a revealer, and in case of moving the mouse to the top of the screen, showing the revealer contents. This is a bit of code duplication, it might be worth having something like this in Gtk+ for fullscreen windows, but until we will have it, we could do the same as gedit. Any objections?

Revision history for this message
Danielle Foré (danrabbit) wrote :

Yeah that's probably a good compromise

Robert Roth (evfool)
Changed in scratch:
assignee: nobody → Robert Roth (evfool)
Robert Roth (evfool)
Changed in scratch:
assignee: Robert Roth (evfool) → nobody
Danielle Foré (danrabbit)
Changed in maya:
status: Fix Committed → Fix Released
Revision history for this message
Robert Roth (evfool) wrote :

Bountysource link: https://www.bountysource.com/issues/1423135-unable-to-access-headerbar-in-fullscreen

summary: - Unable to access HeaderBar in fullscreen
+ Unable to access HeaderBar in fullscreen [$15]
Revision history for this message
Viko Adi Rahmawan (vikoadi) wrote :

in my branch, provide toolbar in revealer,
toolbar hooking still doesnt work
restoring in fullscreen mode also doesnt work

Changed in scratch:
assignee: nobody → Viko Adi Rahmawan (vikoadi)
Revision history for this message
Viko Adi Rahmawan (vikoadi) wrote :

should be working now

Changed in scratch:
status: Confirmed → In Progress
Cody Garver (codygarver)
Changed in scratch:
assignee: Viko Adi Rahmawan (vikoadi) → Cody Garver (codygarver)
status: In Progress → Fix Released
Cody Garver (codygarver)
Changed in scratch:
assignee: Cody Garver (codygarver) → Viko Adi Rahmawan (vikoadi)
status: Fix Released → In Progress
Cody Garver (codygarver)
Changed in scratch:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.