OpenStack Identity (keystone)

Import of unexisting openstack.common.test.py file

Bug #1255532 reported by Ilya Pekelny on 2013-11-27

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Undecided	Ilya Pekelny	OpenStack Compute (nova) 2014.2 "juno"
	OpenStack Identity (keystone)	Fix Released	Low	Ilya Pekelny	OpenStack Identity (keystone) 2014.1 "icehouse"

Bug Description

In keystone/openstack/common/db/sqlalchemy/test_migrations.py, line 30 imports `test` what is not exists. Oslo project contains appropriate file. Solution — synchronize keystone.openstack.common with corresponding file in Oslo.
The bug reproduces under nosetests.

See original description

Ilya Pekelny (i159) on 2013-11-27

Changed in keystone:
assignee:	nobody → Ilya Pekelny (i159)
status:	New → In Progress

Ilya Pekelny (i159) on 2013-11-27

description:	updated
description:	updated

Revision history for this message

Viktor Serhieiev (vsergeyev) wrote on 2013-11-27:

IMO, if you add `test` module, it should be enough to fix this bug.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2013-11-29: Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59199

Dolph Mathews (dolph) on 2013-12-02

Changed in keystone:
importance:	Undecided → Low

Revision history for this message

Ilya Pekelny (i159) wrote on 2013-12-10:

Fixed by: https://review.openstack.org/#/c/59600/

Changed in keystone:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2014-01-22

Changed in keystone:
milestone:	none → icehouse-2
status:	Fix Committed → Fix Released

Revision history for this message

Joe Gordon (jogo) wrote on 2014-02-17:

not sure why this bug has nova on it too.

Changed in nova:
status:	New → Incomplete

Thierry Carrez (ttx) on 2014-04-17

Changed in keystone:
milestone:	icehouse-2 → 2014.1

Ilya Pekelny (i159) on 2014-04-22

Changed in nova:
status:	Incomplete → In Progress
assignee:	nobody → Ilya Pekelny (i159)

Revision history for this message

Openstack Gerrit (openstack-gerrit) wrote on 2014-04-23: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89778

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-05-23: Fix merged to nova (master)

Reviewed: https://review.openstack.org/89778
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0f07f8546fda9732a7e3597a2de78156f1fb5a34
Submitter: Jenkins
Branch: master

commit 0f07f8546fda9732a7e3597a2de78156f1fb5a34
Author: Ilya Pekelny <email address hidden>
Date: Thu May 15 17:37:48 2014 +0300

Sync common db and db/sqlalchemy

    To use db/sqlalchemy/test_base.py we need the test.py file, which does
    not synced to Nova. Latest common db.sqlalchemy uses oslotest. The problem with
    unexisting common/test.py is solved implicitly with synchronization of common
    code.

Contains oslo-incubator commits:

    54f7e7f Prevent races in opportunistic db test cases
    8a0f581 Use oslotest instead of common test module
    4a591ea Start ping listener also for postgresql
    f0e50ed Add a warning to not use get_table for working with ForeignKeys
    2fd457b Ignore migrate versioning tables in utf8 sanity check
    9fed4ed Fix Keystone doc build errors with SQLAlchemy 0.9
    f7705f3 Make table utf-8 charset checking be optional for DB migration
    5b7e61c Dispose db connections pool on disconnect
    295fcd9 Do not use the 'extend' method on a dict_items object
    d1988b9 Set sql_mode callback on connect instead of checkout
    a1a8280 Fix excessive logging from db.sqlalchemy.session
    dc2d829 Add lockutils fixture to OpportunisticTestCase
    d10f871 Adapt DB provisioning code for CI requirements
    5920bed Make db utils importable without migrate
    9933bdd Get mysql_sql_mode parameter from config
    96a2217 Prevent incorrect usage of _wrap_db_error()
    6cab37c Python3: define a __next__() method for ModelBase
    20a7510 Add from_config() method to EngineFacade
    fea119e Drop special case for MySQL traditional mode, update unit tests
    a584166 Make TRADITIONAL the default SQL mode
    5b9e9f4 Fix doc build errors in db.sqlalchemy

Closes-Bug: #1255532
Change-Id: If26b648dee95abc5aa0bf80d3111265b00141b6d

Reviewed:  https://review.openstack.org/89778
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0f07f8546fda9732a7e3597a2de78156f1fb5a34
Submitter: Jenkins
Branch:    master

commit 0f07f8546fda9732a7e3597a2de78156f1fb5a34
Author: Ilya Pekelny <ipekelny@mirantis.com>
Date:   Thu May 15 17:37:48 2014 +0300

Sync common db and db/sqlalchemy
    
    To use db/sqlalchemy/test_base.py we need the test.py file, which does
    not synced to Nova. Latest common db.sqlalchemy uses oslotest. The problem with
    unexisting common/test.py is solved implicitly with synchronization of common
    code.
    
    Contains oslo-incubator commits:
    
    54f7e7f Prevent races in opportunistic db test cases
    8a0f581 Use oslotest instead of common test module
    4a591ea Start ping listener also for postgresql
    f0e50ed Add a warning to not use get_table for working with ForeignKeys
    2fd457b Ignore migrate versioning tables in utf8 sanity check
    9fed4ed Fix Keystone doc build errors with SQLAlchemy 0.9
    f7705f3 Make table utf-8 charset checking be optional for DB migration
    5b7e61c Dispose db connections pool on disconnect
    295fcd9 Do not use the 'extend' method on a dict_items object
    d1988b9 Set sql_mode callback on connect instead of checkout
    a1a8280 Fix excessive logging from db.sqlalchemy.session
    dc2d829 Add lockutils fixture to OpportunisticTestCase
    d10f871 Adapt DB provisioning code for CI requirements
    5920bed Make db utils importable without migrate
    9933bdd Get mysql_sql_mode parameter from config
    96a2217 Prevent incorrect usage of _wrap_db_error()
    6cab37c Python3: define a __next__() method for ModelBase
    20a7510 Add from_config() method to EngineFacade
    fea119e Drop special case for MySQL traditional mode, update unit tests
    a584166 Make TRADITIONAL the default SQL mode
    5b9e9f4 Fix doc build errors in db.sqlalchemy
    
    Closes-Bug: #1255532
    Change-Id: If26b648dee95abc5aa0bf80d3111265b00141b6d

Changed in nova:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2014-06-11

Changed in nova:
milestone:	none → juno-1
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2014-10-16

Changed in nova:
milestone:	juno-1 → 2014.2

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.