launchpad.net/goose/... tests fail with gccgo
Bug #1254564 reported by
Michael Hudson-Doyle
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Go OpenStack Exchange |
Fix Released
|
High
|
Unassigned | ||
juju-core |
Fix Released
|
High
|
Unassigned |
Bug Description
As attached.
Related branches
lp://staging/~mwhudson/goose/gccgo-compat
- Dave Cheney (community): Approve
- John A Meinel: Approve
-
Diff: 78 lines (+38/-5)2 files modifiednova/nova.go (+10/-2)
testservices/hook/service.go (+28/-3)
lp://staging/~dave-cheney/goose/goose
Ready for review
for merging
into
lp://staging/goose
- Michael Hudson-Doyle: Approve
- John A Meinel: Approve
-
Diff: 48 lines (+3/-6)3 files modifiednova/local_test.go (+1/-2)
testservices/novaservice/service_http.go (+1/-1)
testservices/service.go (+1/-3)
lp://staging/~dave-cheney/goose/001-move-gccgo-specific-code-to-individual
- Juju Engineering: Pending requested
-
Diff: 133 lines (+61/-46)3 files modifiedtestservices/hook/service.go (+0/-46)
testservices/hook/service_gc.go (+24/-0)
testservices/hook/service_gccgo.go (+37/-0)
Changed in juju-core: | |
importance: | Medium → High |
Changed in goose: | |
importance: | Medium → High |
Changed in juju-core: | |
milestone: | 1.17.1 → 1.17.0 |
Changed in goose: | |
status: | Fix Committed → Fix Released |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think this is mostly because testservices/ hook/service. go:currentServi ceMethodName doesn't work as expected with gccgo, which means the RegisterControl Point machinery doesn't work and so all of the test double insertion that the test suite relies upon doesn't happen.