gnetlist may ignore non graphical symbols

Bug #1254413 reported by Patrick Bernaud
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA
Fix Released
Undecided
Unassigned

Bug Description

gnetlist considers any symbol with a 'graphical=' attribute as graphical/unconnected while the documentation say that a symbol is a graphical symbol only if the value of the attribute '1'.

The attached patch fixes the test in gnetlist. Or the documentation for the attribute may be changed to take any value of 'graphical=' as true.

Problem reported by Russell Steick on geda-help.

Tags: docs gnetlist
Revision history for this message
Patrick Bernaud (patrickb) wrote :
Revision history for this message
Vladimir Zhbanov (vzhbanov) wrote :

According to the Master Attribute Document, only symbols
containing 'graphical=1' must be ignored by gnetlist (see
http://wiki.geda-project.org/geda:master_attributes_list#graphical).
Any other values of this attribute are not mentioned.

A schematic for testing this bug and the proposed patch is
attached. The command to test is:
  gnetlist -g geda -o /dev/stdout test.sch |grep R2

The patch applies cleanly to the current master HEAD (272be87).

Changed in geda:
status: New → Confirmed
Revision history for this message
gpleda.org commit robot (gpleda-launchpad-robot) wrote :

Bug was fixed by a commit
git master commit 89262be4f19c607631927475579cc9b0eb893ad3
http://git.geda-project.org/geda-gaf/commit/?id=89262be4f19c607631927475579cc9b0eb893ad3

commit 89262be4f19c607631927475579cc9b0eb893ad3
Author: Patrick Bernaud <email address hidden>
Commit: Edward Hennessy <email address hidden>

    gnetlist: Fix test for detection of graphical symbols.

    Closes-bug: lp-1254413

    Signed-off-by: Edward Hennessy <email address hidden>

Changed in geda:
status: Confirmed → Fix Committed
Revision history for this message
Edward Hennessy (ehennes) wrote :

Thank you both for providing a patch and a test file.

Peter TB Brett (peter-b)
Changed in geda:
milestone: none → 1.9.1
Peter TB Brett (peter-b)
Changed in geda:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.