NetworkReply uses the pimpl patter when it is not needed
Bug #1250990 reported by
Manuel de la Peña
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
Medium
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
NetworkReply is not going to be exposed and therefore the pimpl patter is not required.
Related branches
lp://staging/~mandel/ubuntu-download-manager/remove-network-reply-pimpl
- PS Jenkins bot: Approve (continuous-integration)
- Manuel de la Peña (community): Approve
- Diego Sarmentero (community): Approve
-
Diff: 392 lines (+57/-252)5 files modifiedlibubuntudownloadmanager/system/network_reply.cpp (+52/-98)
libubuntudownloadmanager/system/network_reply.h (+5/-5)
ubuntu-download-manager-tests/system/test_network_reply.cpp (+0/-93)
ubuntu-download-manager-tests/system/test_network_reply.h (+0/-54)
ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro (+0/-2)
Changed in ubuntu-download-manager: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-download-manager at revision 195, scheduled for release in ubuntu- download- manager, milestone 0.3