Bug #1250437 “brightness_test needs to use the same heuristic to...” : Bugs : Checkbox Provider - Base

brightness_test needs to use the same heuristic to get_best_interface as gsd-backlight-helper

Bug #1250437 reported by Brendan Donegan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Fix Released
Undecided
Unassigned

Bug Description

In the brightness_test script that we have which sets the brightness, we have a piece of code which selects the backlight interface to use, using the following heuristic:

# Let's prefer the driver specific interface
# over the more common acpi_video one

This is not the same as the one recommended by the kernel, which is documented here: https://www.kernel.org/doc/Documentation/ABI/stable/sysfs-class-backlight

We should use this one, because in the end it will be used by the software which controls the backlight from a user point of view - as it already is by gsd-backlight-helper: https://github.com/GNOME/gnome-settings-daemon/blob/9cdd9923cd2b35305ae63e020c893528ec2703a4/plugins/power/gsd-backlight-linux.c#L49

Related branches

Daniel Manrique (roadmr)
Changed in checkbox:
status: New → Fix Committed
Zygmunt Krynicki (zyga)
affects: checkbox → plainbox-provider-checkbox
Daniel Manrique (roadmr)
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
milestone: none → 0.5
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Loading subscribers...

Remote bug watches

Bug watches keep track of this bug in other bug trackers.