Add functionality to restore closed tabs

Hello Ari,

I think the context menu and closing all tabs to the left/right should not be a problem to add... I'll look into it as soon as find some spare time.

Recovering closed tabs is something that I don't like to much since it would add another layer of state to the program which conflicts with keeping it simple IMHO. Also, I think that neither Firefox nor Chrome are good role models for qpdfview as these are huge programs that offer much more functionality that I really don't want to chase after in this more or less single-person project.

Best regards, Adam.

Hi Adam,

> I think the context menu and closing all tabs to the left/right should not be a problem to add... I'll look into it as soon as find some spare time.

Sounds great! I'll be glad to do help out with any testing needed when the time comes.

> Recovering closed tabs is something that I don't like to much since it would add another layer of state to the program which conflicts with keeping it simple IMHO. Also, I think that neither Firefox nor Chrome are good role models for qpdfview as these are huge programs that offer much more functionality that I really don't want to chase after in this more or less single-person project.

Understood. Leaving this feature request be is absolutely fine with me. It would have been more or less redundant to the "recently closed" list anyway.

Thanks again for all your hard work on qpdfview. What you have created here is truly remarkable.

Cheers
-- Ari

Hello again,

Am 25.10.2013 14:57, schrieb Ari:
> Hi Adam,
>
>> I think the context menu and closing all tabs to the left/right should
> not be a problem to add... I'll look into it as soon as find some spare
> time.
>
> Sounds great! I'll be glad to do help out with any testing needed when
> the time comes.
>
>> Recovering closed tabs is something that I don't like to much since it
> would add another layer of state to the program which conflicts with
> keeping it simple IMHO. Also, I think that neither Firefox nor Chrome
> are good role models for qpdfview as these are huge programs that offer
> much more functionality that I really don't want to chase after in this
> more or less single-person project.
>
> Understood. Leaving this feature request be is absolutely fine with me.
> It would have been more or less redundant to the "recently closed" list
> anyway.

Just to spell it out: I don't think the feature you suggest is
completely out of scope, but every bit of functionality adds a
maintenance cost which, after summing it up, I don't feel comfortable
carrying on my own. But if/when new contributors step up, we should
definitely consider expanding several functional aspects of the program
including this one.

> Thanks again for all your hard work on qpdfview. What you have created
> here is truly remarkable.

Thank you.

> Cheers
> -- Ari
>

Best regards, Adam.

Ok, trunk revision 1344 contains a tab context menu with actions to close all tabs to the left/right or all tabs but this one. (Dailydebs should be rebuilt in an hour or two.)

Hello Adam,

I've been testing rev. 1344 for the past day and everything is working great here. I really like how you've made the tab actions bidirectional. Honestly, I never understood why web browsers didn't do that in the first place.

I have never coded anything - let alone maintained a project - but I think I have a better grasp now of what a time investment it can be. In light of this I am even more thankful for this feature and your swift implementation!

Cheers
-- Ari

Hello again,

since I have a bit of time on my hands, I tried implementing this: As usually, there is a setting "Track recently closed" to control whether the functionality is enabled and how many tabs are tracked (which is effective only after restart). Note that this can significantly increase memory usage as all intermediate data like cached pixmaps or modified forms and annotations are restored (i.e. the document views are just not destroyed and a closed tab takes just as much memory as any other invisible tab).

Please test and report your findings here. Thank you!

Best regards, Adam.

I renamed the setting to "Keep recently closed" to better indicate the actual functionality...

I don't know why, but somehow I completely forgot to comment on this report. Thanks for implementing this feature!