Update the FS is_outdated function to have a hash option
Bug #1242935 reported by
Matt Jones
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Raise |
Invalid
|
High
|
Unassigned | ||
Bug Description
There are two options for checking if a file has changed:
1. Check if the timestamp & size is different. Could potentially be wrong, but is faster.
2. Check if the file hash is different. Should always be accurate, but is slower.
We are currently using only the timestamp. Update the FS is_outdated function to use both.
Make the timestamp + size the default.
| Changed in raise: | |
| milestone: | 0.3.0 → 0.4.0 |
Revision history for this message
| Matt Jones (workhorsy) wrote | #1 |
| Changed in raise: | |
| status: | Confirmed → Invalid |
To post a comment you must log in.
This bug is just asking the wrong question. The FS.is_outdated function almost always is comparing two different files. EG: The source code and the binary result. The bug assumes we are comparing the same file. So it won't work for this case.
So here is makes sense to just stick with comparing the time stamp.