Bug #1237324 “WatchRule tests could fail” : Bugs : OpenStack Heat

WatchRule tests could fail

Bug #1237324 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Steven Hardy

Bug Description

As discussed here:

https://review.openstack.org/#/c/43571/14/heat/tests/test_engine_service.py

There is a potential issue with the way we check watch rules in the test, which means the test could fail if test_show_watch_metric and test_show_watch are run in parallel

Steven Hardy (shardy)
Changed in heat:
importance: Undecided → High
assignee: nobody → Steven Hardy (shardy)
milestone: none → 2013.1.4
milestone: 2013.1.4 → havana-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/50659

Changed in heat:
status: New → In Progress
Steven Hardy (shardy)
tags: added: havana-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/50659
Committed: http://github.com/openstack/heat/commit/f9ee0e0746711a07badb2aae00291ca2a803969c
Submitter: Jenkins
Branch: master

commit f9ee0e0746711a07badb2aae00291ca2a803969c
Author: Steven Hardy <email address hidden>
Date: Wed Oct 9 15:41:07 2013 +0100

    Fix possible race issue with test_engine_service

    There's the potential for racy behavior in test_show_watch, because
    the result of show_watch(self.ctx, watch_name=None) is all watches
    visible to the user, not only those for a specific stack. So it's
    possible that the result length will be more than two, and since the
    watch name is also not unique, we could see spurious test failures.

    So make the test assertions more specific, and avoid reusing the same
    watch name in test_show_watch_metric.

    Change-Id: Ibb1cbae04dee4b6c4ada44336143fd122a3cb53f
    Closes-Bug: #1237324

Changed in heat:
status: In Progress → Fix Committed
Steven Hardy (shardy)
no longer affects: heat/grizzly
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/50883

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (milestone-proposed)

Reviewed: https://review.openstack.org/50883
Committed: http://github.com/openstack/heat/commit/b5a04a0defdd19ff8a021942beb2797a969afebe
Submitter: Jenkins
Branch: milestone-proposed

commit b5a04a0defdd19ff8a021942beb2797a969afebe
Author: Steven Hardy <email address hidden>
Date: Wed Oct 9 15:41:07 2013 +0100

    Fix possible race issue with test_engine_service

    There's the potential for racy behavior in test_show_watch, because
    the result of show_watch(self.ctx, watch_name=None) is all watches
    visible to the user, not only those for a specific stack. So it's
    possible that the result length will be more than two, and since the
    watch name is also not unique, we could see spurious test failures.

    So make the test assertions more specific, and avoid reusing the same
    watch name in test_show_watch_metric.

    Change-Id: Ibb1cbae04dee4b6c4ada44336143fd122a3cb53f
    Closes-Bug: #1237324

Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: havana-rc2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Loading subscribers...

Remote bug watches

Bug watches keep track of this bug in other bug trackers.