widelands

Construction costs tooltip - Iron icon displaced

Bug #1232679 reported by Tino
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Widelands media development
Fix Released
Undecided
Unassigned
widelands
Fix Released
Medium
Unassigned
widelands build18-rc1

Bug Description

I've found only one building which needs iron, the barbarian port.
The tooltip for the build materials shows the iron icon a bit displaced, see attached screenshot.

All building windows for iron consuming buildings or HQ, warehouse or the port itself show the storage for iron fine, you'll notice only the icons a bit sifted upwards in respect to the other icons.

Not sure why the problem is only visible for the port tooltip and if a correction of the hotspot won't mess with the display in other buildings.

Tags: ui graphic
Revision history for this message
Tino (tino79) wrote :

Forgot the screenshot...

Revision history for this message
Tino (tino79) wrote :

I've changed the bug titel, it is no hotspot problem, changing it in the conf does not change anything.
Seems it is caused by the 'abnormal' and non quadratic size of the png.

summary: - Hotspot for iron is a bit off
+ Construction costs tooltip - Iron icon displaced
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Nice catch.

I believe this is simply due to the size of the image used. The icon for gold (tribes/barbarians/gold/menu.png) is 24x24px, but iron (tribes/barbarians/iron/menu.png) is merely 24x15px. The size used by gold, also seemed consistent for some other random wares I checked. I suppose it will be sufficient to expand the iron image to include the missing pixels, probably by centering the iron bar itself. A relevant question is whether this can simply be done in the widelands branch or if the better way is to go through widelands-media and the original first? (I know little of how the graphics development work)

If this is a graphics-only fix, I see the potential for regressions as very little/non-existing, so I think we should aim to get this in before build18. If others disagree, feel free to retarget it to later.

PS. There's similar differences between wares in the size of idle.png, but these seem a lot less consistent.

Changed in widelands-media:
status: New → Confirmed
Changed in widelands:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → build18-rc1
tags: added: graphics ui
tags: added: graphic
removed: graphics
Revision history for this message
SirVer (sirver) wrote :

I think it is safe to merge it. It seems to be a small change and it only makes the graphics more consistent.

And we have a bunch of bugs on our list that will delay b18 anyways for a while longer.

SirVer (sirver)
Changed in widelands-media:
status: Confirmed → Fix Committed
Changed in widelands:
status: Confirmed → Fix Committed
Revision history for this message
SirVer (sirver) wrote :

Released in build-18 rc1.

Changed in widelands:
status: Fix Committed → Fix Released
Changed in widelands-media:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.