[Clock] [Weather] Return more fine-grained territorial divisions for city search results
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Clock App |
Fix Released
|
Medium
|
Nekhelesh Ramananthan | ||
Ubuntu UX |
Fix Released
|
Medium
|
Unassigned | ||
Ubuntu Weather App |
Fix Released
|
Medium
|
Martin Borho |
Bug Description
Both the Weather and Clock app feature functionality to add a city to provide data for. The workflow or adding the city via a search is the same, and we should also unify the data provider.
We want to ensure we provide results that are fine-grained enough in terms of territorial divisions that duplicate names of cities can be differentiated from each other. That is, the data we get should enable us to fix bug 1226834.
So far we've been considering:
- Geonames.org (used by clock already)
- Mapquest
We've come to the conclusion to use geonames.org. This will mean:
- For Clock: add at least adminName2 from geonames.org when we get duplicate results
- For Weather: add adminName1 and at least adminName2 from geonames.org when we get duplicate results
[1] See the results for a duplicate UK city, where adminName2 provides the http://
Related branches
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Paolo Rotolo (community): Approve
-
Diff: 73 lines (+35/-13)1 file modifiedclock/WorldClock.qml (+35/-13)
- Raúl Yeguas: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 827 lines (+365/-159)16 files modifiedcomponents/AddLocationSheet.qml (+30/-27)
components/CitiesList.js (+65/-0)
components/CountryCodes.js (+17/-0)
components/CurrentWeather.qml (+18/-0)
components/DateComponent.qml (+17/-0)
components/GradientsMap.js (+17/-1)
components/LastUpdatedComponent.qml (+1/-0)
components/LocationManagerSheet.qml (+4/-5)
components/Storage.qml (+27/-0)
components/WeatherApi.js (+121/-112)
components/WeatherDetailComponent.qml (+17/-0)
components/WeatherTemperatureComponent.qml (+17/-0)
tests/autopilot/ubuntu_weather_app/tests/test_locationmanager.py (+3/-3)
tests/autopilot/ubuntu_weather_app/tests/test_settings.py (+8/-8)
tests/autopilot/ubuntu_weather_app/tests/weatherdata.py (+2/-3)
ubuntu-weather-app.qml (+1/-0)
Changed in ubuntu-clock-app: | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in ubuntu-weather-app: | |
status: | New → Triaged |
importance: | Undecided → Medium |
description: | updated |
Changed in ubuntu-clock-app: | |
milestone: | none → hack-days-1309 |
Changed in ubuntu-weather-app: | |
assignee: | nobody → Martin Borho (martin-borho) |
description: | updated |
tags: | added: bitesize |
summary: |
- Use the same city search service for Weather and Clock + Return more fine-grained territorial divisions for city search results |
tags: | added: avengers |
Changed in ubuntu-weather-app: | |
status: | Triaged → In Progress |
Changed in ubuntu-clock-app: | |
status: | Triaged → In Progress |
assignee: | nobody → Nekhelesh Ramananthan (nik90) |
Changed in ubuntu-ux: | |
assignee: | nobody → Christina Li (christina-li) |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in ubuntu-clock-app: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-weather-app: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-ux: | |
assignee: | Christina Li (christina-li) → Giorgio Venturi (giorgio-venturi) |
summary: |
- Return more fine-grained territorial divisions for city search results + [Clock] [Weather] Return more fine-grained territorial divisions for + city search results |
Changed in ubuntu-ux: | |
status: | Triaged → Fix Released |
I'm leaning more towards geonames.org since:
- It's a service used widely in Ubuntu already: in the installer and the time indicator
- Being used in Ubuntu means that the usage and license of the data should already be taken care of
- The service has proven to be reliable for Ubuntu so far
- The data we're missing to make duplicate results distinctive is available in geonames.org, we just need to display it (this needs testing, but I believe we need only adminName2 or adminName3)