nec plugin: packetfilter table network_id nullable should be False in folsom_initial db migration

Bug #1229508 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Akihiro Motoki

Bug Description

From the initial commit of NEC plugin, network_id of packetfilters table is nullable=False [1],
but in folsom_initial db migration script nullable is set to True.

nullable=False is just a more strict constraint than nullable=True,
so NEC plugin works but it is better to be fixed in the migration.

I will add the migration to network_id to nullable=False both upgrade and downgrade
to make sure nullable=False in any revision.

[1] https://github.com/openstack/neutron/blob/stable/folsom/quantum/plugins/nec/db/models.py#L53

Tags: nec
Akihiro Motoki (amotoki)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/47962

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/47962
Committed: http://github.com/openstack/neutron/commit/752b7ab29ddc75d8ae54c52d824ecc94a9551b56
Submitter: Jenkins
Branch: master

commit 752b7ab29ddc75d8ae54c52d824ecc94a9551b56
Author: Akihiro MOTOKI <email address hidden>
Date: Tue Sep 24 12:19:41 2013 +0900

    Ensure nullable=False for netid in packetfilters table

    From the initial commit of NEC plugin, network_id of packetfilters
    table is nullable=False, but in folsom_initial db migration script
    nullable is set to True. This commit ensure nullable=False for
    network_id in packetfilters table in any migration revision.

    Change-Id: I2f1ebc16b57d8d6548255079c66d326d97fda5b6
    Closes-Bug: #1229508

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.