When attempting to confirm a draft sales order that raises connector exceptions, the user must first ignore the exceptions, then attempt to confirm the sales order again. This seems unnecessary to me, because the exceptions are only visible when attempting to confirm the order in the first place. That is, if a user chooses to ignore exceptions, he or she has already expressed intent to confirm the order.
Firing the workflow in the sale exception wizard eliminates the need for extra button presses and streamlines the sale confirmation dialog:
if form.ignore:
self.pool.get('sale.order').write(cr, uid, form.sale_id.id,
{'ignore_exceptions': True}, context=context)
wf_service = netsvc.LocalService('workflow')
wf_service.trg_validate(uid, 'sale.order', form.sale_id.id, 'order_confirm', cr)
return {'type': 'ir.actions.act_window_close'}
A patch is attached.
Hi Brendan,
Thanks for the patch.
Originally, the sales exception module behaved as you suggest [0].
Doing the confirmation here breaks the modularity if we want to use the wizard in another manner. The thing is that I couldn't find anymore why we needed to use it in another manner... but I think that we needed to be able to check if there are exceptions on a sales order even before clicking on the confirm button.
Anyway, this is often a matter of confusion for the users, so I agree with this change and, if the need for the wizard which doesn't confirm comes again, we can introduce an boolean argument for that.
I would like to have other opinions on this change, if someone else see any valid reason not to do that though.
[0] http://