Scratch

Use "edit-find-replace-symbolic" in search and replace

Bug #1221799 reported by swizzle
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Scratch
Fix Released
Low
Danielle Foré
Scratch 2.1

Bug Description

The second find bar text fild which contains the place holder replace with has a find icon in the text field.
This monochrome find icon should be replaced by the colored search replace icon (but obviously also by a monochrome one).

It makes more sense to have search replace icon in the text field itself.

Related branches

lp://staging/~elementary-apps/scratch/fix-1221799
Julián Unrrein (community): Approve
Diff: 18 lines (+2/-1)
1 file modified
src/Widgets/SearchManager.vala (+2/-1)
Mario Guerriero (mefrio-g)
Changed in scratch:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 2.1
Revision history for this message
Cody Garver (codygarver) wrote :

Design team, what icon is it supposed to be?

Changed in scratch:
assignee: nobody → elementary UX Team (elementary-design)
Revision history for this message
Danielle Foré (danrabbit) wrote :

edit-find-replace-symbolic

Changed in scratch:
assignee: elementary UX Team (elementary-design) → nobody
Revision history for this message
Cody Garver (codygarver) wrote :

Fixing this bug would also fix the deprecated icon:

src/Widgets/SearchManager.vala

replace_tool_button = new Gtk.ToolButton.from_stock (Gtk.Stock.FIND_AND_REPLACE);

Danielle Foré (danrabbit)
summary: - Redesign search/replace
+ Use "edit-find-replace-symbolic" in search and replace
Revision history for this message
Danielle Foré (danrabbit) wrote :

Cody, I think that's probably a separate report.

I don't think using the primary entry icon for the replace action makes as much sense as OP thinks it does. We usually put actions in the secondary position and options or descriptions in the primary position. In this case, "clear" is already in the secondary position. So I think the action icon for replace would stay right where it is.

Revision history for this message
Danielle Foré (danrabbit) wrote :

That, and we usually don't group bug reports so...

Danielle Foré (danrabbit)
Changed in scratch:
milestone: isis-beta1 → isis-beta2
Revision history for this message
Robert Roth (evfool) wrote :

The only problem I see with this is that there is no symbolic variant of 'edit-find-replace' in either Adwaita or Elementary Icons, and using the 'edit-find-replace' icon looks awful. Daniel, can we get a symbolic find and replace in the elementary icon theme?

Changed in scratch:
assignee: nobody → Daniel Fore (danrabbit)
Robert Roth (evfool)
Changed in scratch:
status: Confirmed → Incomplete
Danielle Foré (danrabbit)
Changed in scratch:
status: Incomplete → In Progress
Julián Unrrein (junrrein)
Changed in scratch:
status: In Progress → Fix Committed
Danielle Foré (danrabbit)
Changed in scratch:
status: Fix Committed → Fix Released
Cody Garver (codygarver)
Changed in scratch:
milestone: freya-beta2 → 2.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.