neutron

neutron.common.log.log does not print module path

Bug #1221663 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Akihiro Motoki
neutron 2013.2 "havana"

Bug Description

neutron.common.log.log is useful for logging arguments of a method.
It outputs class name and method name, but module path is not output.

A module path is useful to search the log message and it is better to contain a module path

[Current]
2013-09-06 17:00:22.021 25612 DEBUG neutron.common.log [-] StubOFCDriver method create_network called with arguments (u'ofc-f1c7f9f5691044f5b5d395d1a7c0', u'ID=8faea3be-66d5-4cbf-8631-810f491c6d0a Name=ext_net at Neutron.', '8faea3be-66d5-4cbf-8631-810f491c6d0a') {} wrapper /opt/stack/neutron/neutron/common/log.py:33

[Proposed]
2013-09-06 17:00:22.021 25612 DEBUG neutron.common.log [-] neutron.tests.unit.nec.stub_ofc_driver.StubOFCDriver method create_network called with arguments (u'ofc-f1c7f9f5691044f5b5d395d1a7c0', u'ID=8faea3be-66d5-4cbf-8631-810f491c6d0a Name=ext_net at Neutron.', '8faea3be-66d5-4cbf-8631-810f491c6d0a') {} wrapper /opt/stack/neutron/neutron/common/log.py:33

Tags: neutron-core
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/45467

Changed in neutron:
status: New → In Progress
Mark McClain (markmcclain)
tags: added: neutron-core
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/45467
Committed: http://github.com/openstack/neutron/commit/155cb48bca9b66fa5188e5c1c63adf696cd6d127
Submitter: Jenkins
Branch: master

commit 155cb48bca9b66fa5188e5c1c63adf696cd6d127
Author: Akihiro MOTOKI <email address hidden>
Date: Sat Sep 7 02:10:57 2013 +0900

    Make neutron.common.log.log print module path

    Closes-Bug: #1221663

    neutron.common.log.log is useful for logging arguments of a method.
    It outputs class name and method name, but module path is not output.
    A module path is useful to search the log message.

    Change-Id: Ic2903da750cc13980d5cdee153bb079f7d4ee122

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-rc1 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.