[needs-packaging] youker-assistant

Bug #1213998 reported by Jack Yu
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Kylin
Fix Released
High
Jack Yu
Ubuntu
Fix Released
Wishlist
Unassigned

Bug Description

'Youker Assistant' is a system assistant tool, and it was written using Qt 4.8, QML and Python. It aimed at helping all users to manage their UbuntuKylin conveniently. It will be installed in UbuntuKylin 13.10, a Chinese flavor of Ubuntu.

Project URL: https://launchpad.net/youker-assistant
Branch to be Uploaded: https://code.launchpad.net/~ubuntukylin-members/youker-assistant/0.1
License: GPL V3+
Notes: Comes in stable versions (0.1).

Revision history for this message
Jack Yu (jackyu) wrote :

Attached is source code.

tags: added: needs-packaging
Changed in ubuntukylin:
importance: Undecided → High
assignee: nobody → Jack Yu (yj-1325)
milestone: none → beta-1
Jack Yu (jackyu)
description: updated
Revision history for this message
Aron Xu (happyaron) wrote :

I did a quick look at the branch without trying to build it, and here are my questions:
1. debian/compat is 8, which should bump to 9 with no other change needed.
2. debian/control says section is "gnome", while the application itself has nothing to do with gnome, it's should be changed to something else more appropriate.
3. debian/control contains a description which is too short, it should be rewritten to be more detailed about what the application does.

Revision history for this message
Brian Murray (brian-murray) wrote :

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

Changed in ubuntu:
importance: Undecided → Wishlist
Revision history for this message
Jack Yu (jackyu) wrote :

Thanks. Attached is the new tarball, merged changes from Robert Bruce Park and comments from Aron Xu.

Revision history for this message
Daniel Holbach (dholbach) wrote :

A few things I noticed:
 - The package fails to build on amd64 because qmake is specified as /usr/lib/i386-linux-gnu/qt4/bin/qmake in Makefile.
 - debian/copyright does not list other copyright holders.
 - Is libphonon-dev required as a dependency?

Revision history for this message
Jack Yu (jackyu) wrote :

New tarball attached, according to dholbach's comments. Thanks.

Revision history for this message
Daniel Holbach (dholbach) wrote :

libphonon (in depends) does not exist as a package with that name - it looks like shlibs:Depends already contains libphonon4 after the build.

I'll leave the rest of the review to the Desktop team.

Revision history for this message
kobe (kobe24-lixiang) wrote :

Yes, there is an error in depends. It should be libphonon4, and it needs phonon-backend-gstreamer to work properly. we had modified it.

Revision history for this message
Jack Yu (jackyu) wrote :

new tarball Attached. Hi developers, any more comments on this project?

Revision history for this message
Daniel Holbach (dholbach) wrote :

Here another very quick review until somebody in -desktop can have another look:
 - the tarball contains .bzr - you might want to remove it from there
 - http://paste.ubuntu.com/6016797/ has uncovered a few more issues, of which
  - desktop-entry-lacks-keywords-entry might be interesting to fix
  - package-contains-empty-directory might be a problem (should files be installed there?)
  - comma-separated-files-in-dep5-copyright should be very easy to fix

Revision history for this message
Aron Xu (happyaron) wrote :

Things to be added (still before trying build the package):

1. The short and long descriptions in debian/control isn't good enough yet, though it's much better than only having one sentence. An example:

Description: integrated tool to aid in routine system maintenance tasks for desktop users
 Youker Assistant is a tool designed to help Ubuntu and UbuntuKylin desktop users manage and
 maintain many aspects of their working environment conveniently in a single application,
 providing a consistent user experience.
 .
 Features currently included:
 * Detecting and displaying general system information
 * Unity user interface customization
 * System garbage cleaning.

2. You may want to split the package into two through debian/control, one is arch:any and the other is arch:all.

Jack Yu (jackyu)
description: updated
Jack Yu (jackyu)
description: updated
Revision history for this message
Jack Yu (jackyu) wrote :

New tarball attached. Fix lintian errors and improve descriptions. Thanks to dholbach and happyaron.

description: updated
Revision history for this message
kobe (kobe24-lixiang) wrote : man page about youker-assistant

 Hi,
/usr/bin/youker-assistant is just the command to start the program. It doesn't like other commands, even it doesn't have OPTIONS or EXAMPLES. It has no any arguments. So it's contents is easy.
We add the man page because of lintian examing report.

Jack Yu (jackyu)
Changed in ubuntu:
status: New → In Progress
Changed in ubuntukylin:
status: New → Fix Committed
status: Fix Committed → In Progress
Jack Yu (jackyu)
Changed in ubuntukylin:
status: In Progress → Fix Released
Changed in ubuntu:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.