neutron

exceptions.AlreadyAttached is not used

Bug #1210276 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Matt Riedemann
neutron 2013.2 "havana"

Bug Description

The neutron.common.exceptions.AlreadyAttached exception is not used. It looks like it's replaced by this exception in the nicira plugin:

https://github.com/openstack/neutron/blob/master/neutron/plugins/nicira/common/exceptions.py#L51

Either common.exceptions.AlreadyAttached should be removed or NvpPortAlreadyAttached should extend the common AlreadyAttached exception class.

Revision history for this message
Matt Riedemann (mriedem) wrote :

Actually, looks like NvpPortAlreadyAttached isn't even used so probably both exceptions can be removed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/40976

Changed in neutron:
assignee: nobody → Matt Riedemann (mriedem)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/40976
Committed: http://github.com/openstack/neutron/commit/fefad06eabc7fb23ccb3ca1a6093d3460065adc7
Submitter: Jenkins
Branch: master

commit fefad06eabc7fb23ccb3ca1a6093d3460065adc7
Author: Matt Riedemann <email address hidden>
Date: Thu Aug 8 14:24:43 2013 -0700

    Remove unused *AlreadyAttached exceptions

    This patch simply removes two exceptions which are not being used.

    Closes-Bug: #1210276

    Change-Id: I5a3412160f49f6e37f3d9182ce4d4a59b1d7bc09

Changed in neutron:
status: In Progress → Fix Committed
Mark McClain (markmcclain)
Changed in neutron:
importance: Undecided → Low
milestone: none → havana-3
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.