hacking: H102, H103 Apache License check violations

Bug #1209070 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Akihiro Motoki

Bug Description

Apache License checks have been added to hacking.py.

    H102 Apache 2.0 license header not found
    H103 Header does not match Apache 2.0 License notice

Some files in neutron do not follow them. The following are examples.
it is better to fix them rather than ignoring them in tox.ini.

<license>!=<apache2>:
'Licensed under the Apache License, Version 2.0 (the 'License'); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.' !=
'Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.'
./neutron/api/v2/attributes.py:6:6: H103 Header does not match Apache 2.0 License notice
# Licensed under the Apache License, Version 2.0 (the 'License'); you may

./neutron/tests/unit/nicira/test_nvp_api_common.py:1:1: H102 Apache 2.0 license header not found
# Copyright (C) 2009-2011 Nicira Networks, Inc. All Rights Reserved.
^

Tags: neutron-core
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/40539

Changed in neutron:
status: New → In Progress
tags: added: neutron-core
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/40539
Committed: http://github.com/openstack/neutron/commit/724735977e35850313b3d73e74238a08dea370e1
Submitter: Jenkins
Branch: master

commit 724735977e35850313b3d73e74238a08dea370e1
Author: Akihiro MOTOKI <email address hidden>
Date: Wed Aug 7 03:48:29 2013 +0900

    Fix H102, H103 Apache 2.0 license hacking check error

    Closes-Bug: #1209070

    This commit addresses H102 and H103 hacking check.
      H102 Apache 2.0 license header not found
      H103 Header does not match Apache 2.0 License notice

    Also ignores H233 hacking check in tox.ini.
      H233 Python 3.x incompatible use of print operator

    Change-Id: I081964bf0b9e21614da2f146bd3ba8d28e211024

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.