OpenStack Heat

Missing resource name produces unintelligible error

Bug #1204157 reported by Clark Torgerson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Davanum Srinivas (DIMS)
OpenStack Heat 2013.2 "havana"

Bug Description

In our initial attempt to create a test template, we mistakenly missed naming a resource. Attempting to validate the template with heat-cfn resulted in a Python error. Naming our resource avoided the error.

Test template: http://pastebin.com/iGGJTBSe
Error: http://pastebin.com/cJR9udEz

Steven Hardy (shardy)
Changed in heat:
status: New → Triaged
importance: Undecided → High
milestone: none → havana-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/38409

Changed in heat:
assignee: nobody → Davanum Srinivas (DIMS) (dims-v)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/38409
Committed: http://github.com/openstack/heat/commit/11c6c3b7d77fb5bef6cdefb3b21dc966314c3692
Submitter: Jenkins
Branch: master

commit 11c6c3b7d77fb5bef6cdefb3b21dc966314c3692
Author: Davanum Srinivas <email address hidden>
Date: Tue Jul 23 23:14:16 2013 -0400

    Fix for bad content inside Resources element

    In validate_template check if we have a dict before we try to
    get 'Type'. We also need to check the response back from
    validate_template to see if there are any 'Error'(s) and present
    that back to the user.

    Fixes LP# 1204157

    Change-Id: I0f636a6a84f6afc9a0aff3089e2bd13a8f88a470

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: havana-3 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.