[enhancement] Implement screen rotation
Bug #1203215 reported by
Chris Gagnon
This bug affects 6 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Daniel van Vugt | ||
| mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| xorg-server (Ubuntu) |
Invalid
|
Medium
|
Unassigned | ||
Bug Description
Steps:
1. running xmir
2. open system settings -> display
Expected result:
screen can be rotated
Actual result:
screen rotation cannot be changed
Related branches
lp://staging/~vanvugt/mir/rotate-output
- Kevin DuBois (community): Approve
- Alan Griffiths: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 1696 lines (+499/-204)47 files modifieddebian/control (+4/-4)
debian/libmirclient6.install (+1/-1)
debian/libmirserver14.install (+1/-1)
examples/demo-shell/window_manager.cpp (+2/-1)
examples/pixel_format_selector.cpp (+2/-1)
examples/server_configuration.cpp (+24/-12)
include/platform/mir/graphics/display_configuration.h (+11/-2)
include/shared/mir_toolkit/client_types.h (+1/-0)
include/shared/mir_toolkit/common.h (+8/-0)
include/test/mir_test_doubles/null_display_configuration.h (+1/-1)
include/test/mir_test_doubles/stub_display_configuration.h (+5/-3)
src/client/CMakeLists.txt (+1/-1)
src/client/display_configuration.cpp (+1/-0)
src/client/mir_connection.cpp (+1/-0)
src/platform/graphics/android/android_display_configuration.cpp (+6/-2)
src/platform/graphics/android/android_display_configuration.h (+4/-2)
src/platform/graphics/display_configuration.cpp (+16/-0)
src/platform/graphics/mesa/cursor.cpp (+2/-0)
src/platform/graphics/mesa/overlapping_output_grouping.cpp (+9/-20)
src/platform/graphics/mesa/real_kms_display_configuration.cpp (+3/-2)
src/platform/graphics/mesa/real_kms_display_configuration.h (+4/-2)
src/server/CMakeLists.txt (+1/-1)
src/server/frontend/protobuf_buffer_packer.cpp (+1/-0)
src/server/frontend/session_mediator.cpp (+9/-3)
src/server/graphics/default_display_configuration_policy.cpp (+9/-5)
src/server/graphics/nested/nested_display.cpp (+3/-4)
src/server/graphics/nested/nested_display_configuration.cpp (+8/-4)
src/server/graphics/nested/nested_display_configuration.h (+4/-2)
src/server/graphics/offscreen/display.cpp (+1/-3)
src/server/graphics/offscreen/display_configuration.cpp (+4/-2)
src/server/graphics/offscreen/display_configuration.h (+5/-2)
src/server/scene/mediating_display_changer.cpp (+2/-1)
src/server/shell/graphics_display_layout.cpp (+1/-1)
src/shared/protobuf/mir_protobuf.proto (+1/-0)
src/utils/out.c (+15/-2)
tests/mir_test/display_config_matchers.cpp (+6/-3)
tests/mir_test_framework/stubbed_server_configuration.cpp (+3/-1)
tests/unit-tests/client/test_client_display_conf.cpp (+1/-0)
tests/unit-tests/frontend/test_session_mediator.cpp (+9/-3)
tests/unit-tests/graphics/android/test_android_fb.cpp (+26/-22)
tests/unit-tests/graphics/mesa/test_cursor.cpp (+6/-3)
tests/unit-tests/graphics/mesa/test_display_configuration.cpp (+14/-7)
tests/unit-tests/graphics/mesa/test_display_multi_monitor.cpp (+23/-12)
tests/unit-tests/graphics/mesa/test_overlapping_output_grouping.cpp (+116/-42)
tests/unit-tests/graphics/nested/test_nested_display_configuration.cpp (+38/-13)
tests/unit-tests/graphics/test_default_display_configuration_policy.cpp (+35/-12)
tests/unit-tests/graphics/test_display_configuration.cpp (+51/-1)
lp://staging/~vanvugt/mir/rotate-display-buffer
- Chris Halse Rogers: Approve
- Kevin DuBois (community): Approve (ok for now)
- Alan Griffiths: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 719 lines (+434/-9)17 files modifiedinclude/platform/mir/graphics/display_buffer.h (+10/-0)
include/test/mir_test_doubles/mock_display_buffer.h (+1/-0)
include/test/mir_test_doubles/null_display_buffer.h (+1/-0)
src/platform/graphics/android/android_display.cpp (+13/-0)
src/platform/graphics/android/display_buffer.cpp (+27/-2)
src/platform/graphics/android/display_buffer.h (+3/-0)
src/platform/graphics/mesa/display.cpp (+18/-3)
src/platform/graphics/mesa/display_buffer.cpp (+25/-2)
src/platform/graphics/mesa/display_buffer.h (+4/-0)
src/server/graphics/nested/nested_output.cpp (+10/-1)
src/server/graphics/nested/nested_output.h (+1/-0)
src/server/graphics/offscreen/display_buffer.cpp (+10/-1)
src/server/graphics/offscreen/display_buffer.h (+1/-0)
tests/unit-tests/graphics/android/test_hwc_display.cpp (+50/-0)
tests/unit-tests/graphics/mesa/CMakeLists.txt (+1/-0)
tests/unit-tests/graphics/mesa/test_display_buffer.cpp (+236/-0)
tests/unit-tests/graphics/offscreen/test_offscreen_display.cpp (+23/-0)
lp://staging/~vanvugt/mir/rotate-renderer
- Alan Griffiths: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Alexandros Frantzis (community): Approve
-
Diff: 288 lines (+47/-18)11 files modifiedinclude/test/mir_test_doubles/mock_surface_renderer.h (+1/-1)
src/server/compositor/default_display_buffer_compositor.cpp (+1/-1)
src/server/compositor/gl_renderer.cpp (+15/-2)
src/server/compositor/gl_renderer.h (+2/-1)
src/server/compositor/renderer.h (+1/-1)
tests/acceptance-tests/test_server_shutdown.cpp (+1/-1)
tests/integration-tests/test_session.cpp (+1/-1)
tests/integration-tests/test_surface_first_frame_sync.cpp (+1/-1)
tests/mir_test_framework/stubbed_server_configuration.cpp (+1/-1)
tests/unit-tests/compositor/test_default_display_buffer_compositor.cpp (+20/-4)
tests/unit-tests/compositor/test_gl_renderer.cpp (+3/-4)
lp://staging/~vanvugt/mir/rotate-using-keyboard
- Kevin DuBois (community): Approve
- Alan Griffiths: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 46 lines (+36/-0)1 file modifiedexamples/demo-shell/window_manager.cpp (+36/-0)
lp://staging/~andreas-pokorny/mir/cursor-position-on-rotated-output
- Alan Griffiths: Approve
- Daniel van Vugt: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Robert Carr (community): Approve
-
Diff: 270 lines (+115/-18)3 files modifiedsrc/platform/graphics/mesa/cursor.cpp (+26/-15)
src/platform/graphics/mesa/cursor.h (+2/-1)
tests/unit-tests/graphics/mesa/test_cursor.cpp (+87/-2)
| summary: |
- unable to rotate screen on intel + unable to rotate screen or change resolution on intel |
| description: | updated |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote Re: unable to rotate screen or change resolution on intel | #1 |
| tags: | added: multimonitor |
| summary: |
- unable to rotate screen or change resolution on intel + unable to rotate screen on intel |
| description: | updated |
| summary: |
- unable to rotate screen on intel + Unable to rotate screen |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote Re: Unable to rotate screen | #2 |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #3 |
Revision history for this message
| kevin gunn (kgunn72) wrote | #4 |
Revision history for this message
| kevin gunn (kgunn72) wrote | #5 |
| Changed in mir: | |
| importance: | Undecided → Critical |
| assignee: | nobody → Alexandros Frantzis (afrantzis) |
| Changed in xmir: | |
| assignee: | nobody → Chris Halse Rogers (raof) |
| importance: | Undecided → Critical |
| Changed in mir: | |
| status: | New → Triaged |
| Changed in xmir: | |
| status: | New → Triaged |
Revision history for this message
| kevin gunn (kgunn72) wrote Re: xmir unable to rotate screens | #6 |
| summary: |
- Unable to rotate screen + xmir unable to rotate screens |
| Changed in mir: | |
| importance: | Critical → High |
| Changed in xmir: | |
| importance: | Critical → High |
| summary: |
- xmir unable to rotate screens + [feature] Implement screen rotation |
| tags: | added: feature |
| summary: |
- [feature] Implement screen rotation + [enhancement] Implement screen rotation |
| tags: |
added: enhancement removed: feature |
| Changed in mir: | |
| assignee: | Alexandros Frantzis (afrantzis) → Daniel van Vugt (vanvugt) |
| status: | Triaged → In Progress |
| milestone: | none → 0.1.5 |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #7 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → In Progress |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → In Progress |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → In Progress |
| Changed in mir: | |
| milestone: | 0.1.5 → 0.1.6 |
| Changed in mir: | |
| importance: | High → Medium |
| Changed in xmir: | |
| importance: | High → Medium |
| Changed in mir: | |
| milestone: | 0.1.6 → 0.1.7 |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #11 |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #12 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → In Progress |
| Changed in mir: | |
| milestone: | 0.1.7 → 0.1.8 |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #13 |
| Changed in mir: | |
| status: | In Progress → Fix Released |
| Changed in mir (Ubuntu): | |
| status: | New → Fix Released |
| Changed in mir: | |
| milestone: | 0.1.8 → 0.1.7 |
| affects: | xmir → xorg-server (Ubuntu) |
| Changed in xorg-server (Ubuntu): | |
| assignee: | Chris Halse Rogers (raof) → Robert Ancell (robert-ancell) |
| tags: | added: xmir |
| Changed in xorg-server (Ubuntu): | |
| assignee: | Robert Ancell (robert-ancell) → nobody |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #14 |
| Changed in xorg-server (Ubuntu): | |
| status: | Triaged → Invalid |
To post a comment you must log in.
Resolution is already covered by bug 1196239. So making this bug just about rotation.