Mir

Intermittent hangs in TestClientInput.clients_receive_key_input and TestClientInput.clients_receive_us_english_mapped_keys tests

Bug #1201435 reported by Alexandros Frantzis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Committed
High
Robert Carr
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

I noticed some Intermittent hangs in TestClientInput.clients_receive_key_input and TestClientInput.clients_receive_us_english_mapped_keys tests. They are present on both Android and the desktop, although they are much more easily reproducible on an Android device. Run each test with --gtest_repeat=N to catch this (and even then may need multiple runs).

Related branches

lp://staging/~robertcarr/mir/client-focus-notifications
PS Jenkins bot (community): Approve (continuous-integration)
kevin gunn (community): Approve
Daniel van Vugt: Needs Fixing
Alan Griffiths: Abstain
Robert Ancell: Approve
Chris Halse Rogers: Approve
Alexandros Frantzis: Pending requested
Diff: 1138 lines (+481/-104)
31 files modified
include/server/mir/frontend/message_processor_report.h (+4/-0)
include/server/mir/frontend/null_message_processor_report.h (+2/-0)
include/server/mir/frontend/shell.h (+2/-0)
include/server/mir/logging/message_processor_report.h (+2/-0)
include/server/mir/lttng/message_processor_report.h (+1/-0)
include/server/mir/shell/default_focus_mechanism.h (+7/-1)
include/server/mir/shell/session_manager.h (+2/-0)
include/shared/mir_toolkit/common.h (+12/-3)
include/test/mir_test/event_matchers.h (+14/-0)
include/test/mir_test_doubles/mock_shell.h (+1/-0)
include/test/mir_test_doubles/stub_shell.h (+4/-1)
include/test/mir_test_framework/input_testing_server_configuration.h (+2/-3)
src/client/mir_connection.cpp (+4/-1)
src/client/mir_surface.cpp (+3/-4)
src/client/mir_surface.h (+1/-1)
src/server/frontend/null_message_processor_report.cpp (+4/-0)
src/server/frontend/session_mediator.cpp (+35/-29)
src/server/frontend/socket_messenger.cpp (+2/-0)
src/server/logging/message_processor_report.cpp (+6/-3)
src/server/lttng/message_processor_report.cpp (+6/-0)
src/server/shell/default_focus_mechanism.cpp (+7/-0)
src/server/shell/session_manager.cpp (+13/-2)
src/server/shell/surface.cpp (+5/-2)
tests/acceptance-tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/test_client_focus_notification.cpp (+232/-0)
tests/acceptance-tests/test_client_input.cpp (+3/-1)
tests/acceptance-tests/test_focus_selection.cpp (+1/-0)
tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp (+7/-0)
tests/mir_test_framework/input_testing_server_options.cpp (+38/-53)
tests/unit-tests/shell/test_default_focus_mechanism.cpp (+26/-0)
tests/unit-tests/shell/test_surface.cpp (+34/-0)
kevin gunn (kgunn72)
Changed in mir:
importance: Undecided → High
status: New → Triaged
assignee: nobody → Robert Carr (robertcarr)
Revision history for this message
Robert Carr (robertcarr) wrote :

This is probably the race in input_testing_server_options referenced in this comment:
https://code.launchpad.net/~robertcarr/mir/client-focus-notifications/+merge/166440/comments/389018

Changed in mir:
status: Triaged → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.0.10

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.0.10+13.10.20130827.1-0ubuntu1

---------------
mir (0.0.10+13.10.20130827.1-0ubuntu1) saucy; urgency=low

  [ Alan Griffiths ]
  * ipc: add a protocol version to the wire protocol so that we can bump
    it in future.
  * graphics::nested: Handling of output configuration changes.
  * graphics.nested: Hookup NestedDisplay to display change
    notifications.

  [ Daniel van Vugt ]
  * Introducing mir_demo_client_progressbar. It's pretty boring;
    designed to simulate key repeat scrolling in a terminal, as an aid
    for tracking down bug 1216472. . (LP: #1216472)

  [ Eleni Maria Stea ]
  * changed the GBMBufferAllocator constructor and class to use the
    gbm_device instead of the GBMPlatform to remove the dependency from
    the mg::Platform interface - this way we can use the
    GBMBufferAllocator with the NativeGBMPlatform (nested mir).

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 1025
 -- Ubuntu daily release <email address hidden> Tue, 27 Aug 2013 18:04:47 +0000

Changed in mir (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.