Glance

Property DB operations are not consistent with the rest of the API

Bug #1199364 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Flavio Percoco
Glance 2013.2 "havana"

Bug Description

Property related functions are not consistent with the rest of the API.

image_property_create returns a models.ImageProperty instance instead of a dictionary as the image function does.

image_property_delete receives an models.ImageProperty instance instead of a reference name.

It is important to:

1) Keep API's consistency
2) Avoid making the DB API back-end dependent.

Flavio Percoco (flaper87)
Changed in glance:
assignee: nobody → Flavio Percoco (flaper87)
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/36218

Changed in glance:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/36218
Committed: http://github.com/openstack/glance/commit/ba17ee92f4110309da305fc2a80941abc997871e
Submitter: Jenkins
Branch: master

commit ba17ee92f4110309da305fc2a80941abc997871e
Author: Flaper Fesp <email address hidden>
Date: Tue Jul 9 15:10:58 2013 +0200

    Make db properties functions consistent with the DB API

    Currently property related functions are not consistent with the
    database API. As for the create operation, the API returns an
    ImageProperty model instead of a dictionary and in the case of the
    delete operation, the function expects a property instance instead of a
    reference name.

    This patch makes both calls consistent by returning a dictionary when a
    property is created and receiving a property name instead of its
    instance when a property needs to be deleted.

    Fixes bug: #1199364
    Implements blueprint registry-db-driver

    Change-Id: Ibc7067cf712942610c7507f22f8895c2d531172a

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → havana-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.