--encrypt-key-file is not covered by the test suite
Bug #1197644 reported by
Alexey Kopytov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
Medium
|
George Ormond Lorch III | ||
| 2.1 |
Fix Released
|
Medium
|
George Ormond Lorch III | ||
Bug Description
xb_encrypt.sh has the following line:
echo -n "Percona XtraBackup is awesome!!!" > $encrypt_key_file
But $encrypt_key_file is not initialized anywhere. That would result in a failed test if xb_encrypt.sh included inc/common.sh (which does "set -eu"), but it's not included in this test.
In my test suite cleanups I changed it so that each test is executed with "set -eu" no matter if and when it includes common.sh (and removed the line which now results in a failure).
But we need --encrypt-key-file coverage anyway.
Related branches
lp://staging/~gl-az/percona-xtrabackup/2.1-bug1197644
- Alexey Kopytov (community): Approve
-
Diff: 26 lines (+9/-4)1 file modifiedtest/t/xb_encrypt.sh (+9/-4)
Revision history for this message
| George Ormond Lorch III (gl-az) wrote | #1 |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
To post a comment you must log in.
Hmmm, that looks like a remnant of when all tests used the key file which I eventually changed to just using the command line option to avoid having random files laying about for every test.
I do remember creating an explicit test for the key file and do not see it in the repository so I wonder if I failed to add it to the bzr tree somewhere along the line. I think now though that instead of creating another explicit test for the key file it would probably be better to just make the basic xb_encrypt test use the key file and let all other tests use the --encrypt-key= instead to help keep the test count down and still have adequate coverage.
I'll get this fixed up and submitted...