Mir

Mir carries its own cucumber version in-tree

Bug #1194075 reported by Didier Roche-Tolomelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Robert Carr
Mir 0.0.6

Bug Description

Can we use the distro versions instead? Does cucumber have C++ bindings in saucy?

Related branches

lp://staging/~robertcarr/mir/remove-cucumber
Robert Ancell: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 8787 lines (+2/-8084)
120 files modified
3rd_party/cucumber-cpp/CMakeLists.txt (+0/-80)
3rd_party/cucumber-cpp/CTestTestfile.cmake (+0/-9)
3rd_party/cucumber-cpp/LICENSE.txt (+0/-21)
3rd_party/cucumber-cpp/README.txt (+0/-47)
3rd_party/cucumber-cpp/cmake/modules/FindCppSpec.cmake (+0/-23)
3rd_party/cucumber-cpp/examples/CMakeLists.txt (+0/-2)
3rd_party/cucumber-cpp/examples/CTestTestfile.cmake (+0/-8)
3rd_party/cucumber-cpp/examples/Calc/CMakeLists.txt (+0/-23)
3rd_party/cucumber-cpp/examples/Calc/CTestTestfile.cmake (+0/-6)
3rd_party/cucumber-cpp/examples/Calc/Calc/Calculator.cpp (+0/-27)
3rd_party/cucumber-cpp/examples/Calc/Calc/Calculator.h (+0/-11)
3rd_party/cucumber-cpp/examples/Calc/CalcFeatures/BoostCalculatorSteps.cpp (+0/-31)
3rd_party/cucumber-cpp/examples/Calc/CalcFeatures/CppSpecCalculatorSteps.cpp (+0/-31)
3rd_party/cucumber-cpp/examples/Calc/CalcFeatures/GTestCalculatorSteps.cpp (+0/-32)
3rd_party/cucumber-cpp/examples/Calc/CalcFeatures/features/addition.feature (+0/-17)
3rd_party/cucumber-cpp/examples/Calc/CalcFeatures/features/division.feature (+0/-10)
3rd_party/cucumber-cpp/examples/Calc/CalcFeatures/features/step_definitons/cucumber.wire (+0/-2)
3rd_party/cucumber-cpp/examples/Calc/README.txt (+0/-2)
3rd_party/cucumber-cpp/examples/FeatureShowcase/CMakeLists.txt (+0/-14)
3rd_party/cucumber-cpp/examples/FeatureShowcase/CTestTestfile.cmake (+0/-6)
3rd_party/cucumber-cpp/examples/FeatureShowcase/table/TableSteps.cpp (+0/-63)
3rd_party/cucumber-cpp/examples/FeatureShowcase/table/features/step_definitions/cucumber.wire (+0/-2)
3rd_party/cucumber-cpp/examples/FeatureShowcase/table/features/table.feature (+0/-14)
3rd_party/cucumber-cpp/examples/FeatureShowcase/tag/TagSteps.cpp (+0/-49)
3rd_party/cucumber-cpp/examples/FeatureShowcase/tag/features/step_definitions/cucumber.wire (+0/-2)
3rd_party/cucumber-cpp/examples/FeatureShowcase/tag/features/tag.feature (+0/-39)
3rd_party/cucumber-cpp/include/cucumber-cpp/defs.hpp (+0/-6)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/ContextManager.hpp (+0/-72)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/CukeCommands.hpp (+0/-44)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/CukeEngine.hpp (+0/-104)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/CukeEngineImpl.hpp (+0/-31)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/Macros.hpp (+0/-8)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/RegistrationMacros.hpp (+0/-35)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/Scenario.hpp (+0/-21)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/Table.hpp (+0/-35)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/connectors/wire/ProtocolHandler.hpp (+0/-21)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/connectors/wire/WireProtocol.hpp (+0/-176)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/connectors/wire/WireProtocolCommands.hpp (+0/-82)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/connectors/wire/WireServer.hpp (+0/-54)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/drivers/BoostDriver.hpp (+0/-25)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/drivers/CppSpecDriver.hpp (+0/-19)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/drivers/DriverSelector.hpp (+0/-9)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/drivers/FakeDriver.hpp (+0/-26)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/drivers/GTestDriver.hpp (+0/-28)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/hook/HookMacros.hpp (+0/-87)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/hook/HookRegistrar.hpp (+0/-149)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/hook/Tag.hpp (+0/-51)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/step/StepMacros.hpp (+0/-50)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/step/StepManager.hpp (+0/-240)
3rd_party/cucumber-cpp/include/cucumber-cpp/internal/utils/Regex.hpp (+0/-59)
3rd_party/cucumber-cpp/include/json_spirit/CMakeLists.txt (+0/-10)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit.h (+0/-18)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_error_position.h (+0/-54)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_reader.cpp (+0/-137)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_reader.h (+0/-62)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_reader_template.h (+0/-612)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_stream_reader.h (+0/-70)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_utils.h (+0/-61)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_value.cpp (+0/-8)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_value.h (+0/-532)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_writer.cpp (+0/-95)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_writer.h (+0/-50)
3rd_party/cucumber-cpp/include/json_spirit/json_spirit_writer_template.h (+0/-245)
3rd_party/cucumber-cpp/src/CMakeLists.txt (+0/-32)
3rd_party/cucumber-cpp/src/CTestTestfile.cmake (+0/-6)
3rd_party/cucumber-cpp/src/ContextManager.cpp (+0/-14)
3rd_party/cucumber-cpp/src/CukeCommands.cpp (+0/-42)
3rd_party/cucumber-cpp/src/CukeEngine.cpp (+0/-43)
3rd_party/cucumber-cpp/src/CukeEngineImpl.cpp (+0/-100)
3rd_party/cucumber-cpp/src/HookRegistrar.cpp (+0/-148)
3rd_party/cucumber-cpp/src/Regex.cpp (+0/-58)
3rd_party/cucumber-cpp/src/Scenario.cpp (+0/-18)
3rd_party/cucumber-cpp/src/StepManager.cpp (+0/-193)
3rd_party/cucumber-cpp/src/Table.cpp (+0/-38)
3rd_party/cucumber-cpp/src/Tag.cpp (+0/-60)
3rd_party/cucumber-cpp/src/connectors/wire/WireProtocol.cpp (+0/-346)
3rd_party/cucumber-cpp/src/connectors/wire/WireProtocolCommands.cpp (+0/-79)
3rd_party/cucumber-cpp/src/connectors/wire/WireServer.cpp (+0/-34)
3rd_party/cucumber-cpp/src/drivers/BoostDriver.cpp (+0/-102)
3rd_party/cucumber-cpp/src/drivers/CppSpecDriver.cpp (+0/-18)
3rd_party/cucumber-cpp/src/drivers/GTestDriver.cpp (+0/-39)
3rd_party/cucumber-cpp/src/main.cpp (+0/-33)
3rd_party/cucumber-cpp/tests/CMakeLists.txt (+0/-46)
3rd_party/cucumber-cpp/tests/CTestTestfile.cmake (+0/-6)
3rd_party/cucumber-cpp/tests/integration/ContextHandlingTest.cpp (+0/-62)
3rd_party/cucumber-cpp/tests/integration/HookRegistrationTest.cpp (+0/-130)
3rd_party/cucumber-cpp/tests/integration/StepRegistrationTest.cpp (+0/-38)
3rd_party/cucumber-cpp/tests/integration/TaggedHookRegistrationTest.cpp (+0/-56)
3rd_party/cucumber-cpp/tests/integration/WireProtocolTest.cpp (+0/-315)
3rd_party/cucumber-cpp/tests/integration/WireServerTest.cpp (+0/-124)
3rd_party/cucumber-cpp/tests/integration/drivers/BoostDriverTest.cpp (+0/-56)
3rd_party/cucumber-cpp/tests/integration/drivers/CppSpecDriverTest.cpp (+0/-28)
3rd_party/cucumber-cpp/tests/integration/drivers/GTestDriverTest.cpp (+0/-59)
3rd_party/cucumber-cpp/tests/unit/BasicStepTest.cpp (+0/-35)
3rd_party/cucumber-cpp/tests/unit/ContextManagerTest.cpp (+0/-53)
3rd_party/cucumber-cpp/tests/unit/CukeCommandsTest.cpp (+0/-98)
3rd_party/cucumber-cpp/tests/unit/RegexTest.cpp (+0/-74)
3rd_party/cucumber-cpp/tests/unit/StepCallChainTest.cpp (+0/-146)
3rd_party/cucumber-cpp/tests/unit/StepManagerTest.cpp (+0/-137)
3rd_party/cucumber-cpp/tests/unit/TableTest.cpp (+0/-69)
3rd_party/cucumber-cpp/tests/unit/TagTest.cpp (+0/-74)
3rd_party/cucumber-cpp/tests/utils/ContextManagerTestDouble.hpp (+0/-19)
3rd_party/cucumber-cpp/tests/utils/CukeCommandsFixture.hpp (+0/-48)
3rd_party/cucumber-cpp/tests/utils/DriverTestRunner.hpp (+0/-177)
3rd_party/cucumber-cpp/tests/utils/HookRegistrationFixture.hpp (+0/-128)
3rd_party/cucumber-cpp/tests/utils/StepManagerTestDouble.hpp (+0/-113)
CMakeLists.txt (+1/-3)
debian/copyright (+0/-25)
include/test/mir_test_cucumber/session_management_context.h (+0/-78)
src/server/shell/consuming_placement_strategy.cpp (+0/-10)
tests/CMakeLists.txt (+1/-2)
tests/behavior-tests/CMakeLists.txt (+0/-35)
tests/behavior-tests/README.txt (+0/-8)
tests/behavior-tests/features/consuming-mode.feature (+0/-32)
tests/behavior-tests/features/step_definitions/cucumber.wire (+0/-2)
tests/behavior-tests/session_management_context.cpp (+0/-175)
tests/behavior-tests/session_manager_steps.cpp (+0/-74)
tests/integration-tests/CMakeLists.txt (+0/-3)
tests/integration-tests/cucumber/CMakeLists.txt (+0/-9)
tests/integration-tests/cucumber/test_session_management_context.cpp (+0/-177)
Didier Roche-Tolomelli (didrocks)
summary: - Ship with a copy of gmock and cucumber
+ Ship with a copy of cucumber
Revision history for this message
Robert Ancell (robert-ancell) wrote : Re: Ship with a copy of cucumber

Robert - is there a particular reason why cucumber is checked in?

Changed in mir:
assignee: nobody → Robert Carr (robertcarr)
status: New → Triaged
Revision history for this message
Stephen M. Webb (bregma) wrote :

Note that the package would be cucumber-cpp, not cucmber (it's not bindings to the Ruby tool, it's a separate implementation to make GTest look like the Ruby tool). The cucumber-cpp library is not packaged for Debian or Ubuntu.

It might be better to rewrite the single unit test to use GTest directly instead of packaging or including the cucumber-cpp library.

Robert Ancell (robert-ancell)
summary: - Ship with a copy of cucumber
+ Mir carries its own cucumber version in-tree
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.0.6

Changed in mir:
status: Triaged → Fix Committed
Robert Ancell (robert-ancell)
Changed in mir:
milestone: none → 0.0.6
Robert Ancell (robert-ancell)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.