juju-gui

nsRouter methods are not querystring or hash aware

Bug #1188784 reported by j.c.sackett
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-gui
Fix Released
Undecided
Benjamin Saller
juju-gui 1366900230

Bug Description

nsRouter.{parse,url} are both unaware of querystrings and hashes. As such they strip them from the url, when they should not.

/foo/bar#baz?fizz=buzz becomes /foo/bar

This has posed problems for the charmbrowser in the past, and will likely become an issue again.

Related branches

lp://staging/~bcsaller/juju-gui/routing-hash-query
Juju GUI Hackers: Pending requested
Diff: 185 lines (+89/-16)
2 files modified
app/assets/javascripts/ns-routing-app-extension.js (+71/-16)
test/test_routing.js (+18/-0)
Benjamin Saller (bcsaller)
Changed in juju-gui:
assignee: nobody → Benjamin Saller (bcsaller)
milestone: none → 1366900230
status: Triaged → In Progress
Gary Poster (gary)
Changed in juju-gui:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.