Glance

Functional tests shouldn't inherit from Isolate IsolatedUnitTest

Bug #1186291 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Flavio Percoco
Glance 2013.2 "havana"

Bug Description

There are some functional tests depending on IsolatedUnitTest which doesn't make much sense. For example:

https://github.com/openstack/glance/blob/master/glance/tests/functional/db/base.py#L63

The issue with this - besides making functional tests inherit from a Unit oriented TestCase - is that IsolatedUnitTests stubs some classes which makes it impossible to write functional tests depending on those classes.

Flavio Percoco (flaper87)
Changed in glance:
importance: Undecided → High
milestone: none → havana-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/31232

Changed in glance:
assignee: nobody → Flavio Percoco (flaper87)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/31232
Committed: http://github.com/openstack/glance/commit/b1a7aca43df0853ea2b5c0fd8b60273e4ad36ed8
Submitter: Jenkins
Branch: master

commit b1a7aca43df0853ea2b5c0fd8b60273e4ad36ed8
Author: Flaper Fesp <email address hidden>
Date: Fri May 31 17:37:14 2013 +0200

    Don't make functional tests inherit from IsolatedUnitTest

    There were some functional tests inheriting from IsolatedUnitTest which
    doesn't make sense and was causing some issues in newer developments
    since IsolatedUnitTest stubs some classes (like Registry's client).

    Fixes bug: #1186291

    Change-Id: Icafac9edf8b0cec6a96532c609923de2c4d8d6bb

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.