leo/plugins/spellpyx.txt is both source controlled and customized

Bug #1175013 reported by SegundoBob
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
leo-editor
Fix Released
Medium
Edward K. Ream

Bug Description

A file that is both source controlled and customized by the user is inconvenient for both novices and experts. Such a file is inconvenient for a novice running Linux because the novice probably does not have write access to leo/plugins/spellpyx.txt. Such a file is inconvenient for an expert who uses Bazaar to pull the latest revision because pulling may require merging the user's customizations with Leo-Editor maintainer changes.

Hence, it is undesirable that file leo/plugins/spellpyx.txt is both source controlled and customized by the user.

Example of user customization:
Copy file leo/plugins/spellpyx.txt to a file, say base.txt.
Run the Leo-Editor spell checker on text containing a word that spell flags as misspelled.
Click the "Add" button in the spell pane.
Now diff leo/plugins/spellpyx.txt and base.txt.
Note that the word you "added" is at the end of leo/plugins/spellpyx.txt.
-------

Suggested fix:

Allow two spell word lists: leo/plugins/spellpyx.txt and ~/.leo/spellpyx.txt

These lists are "additive". That is, any word in either list is accepted.

Make the spell "Add" always add to ~/.leo/spellpyx.txt, creating it if necessary.
-------
Forum thread:
https://groups.google.com/forum/#!topic/leo-editor/HLrqAudBgBw
-------
My test system:
Xubuntu 12.04
Leo Log Window
Leo 4.11 devel, build 5752, 2013-04-27 12:44:31
Python 2.7.3, qt version 4.8.1
linux2
---
I believe the Leo-Editor spell checker has worked this way for a very long time.

Changed in leo-editor:
milestone: none → 4.11-b1
assignee: nobody → Edward K. Ream (edreamleo)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Edward K. Ream (edreamleo) wrote :

Fixed at rev 5990. The checkin log (for rev 5989):

- leo\plugins\spellpyx.txt is no longer part of the distribution.

- EnchantClass ctor calls create to create an empty leo/plugins/spellpyx.txt if necessary.

- clean_dict now takes care to remove blank lines--they cause problems.

- All code now works with Python 3.x.

Changed in leo-editor:
status: Confirmed → Fix Released
Revision history for this message
SegundoBob (bhossley) wrote :

Edward,

Thanks. So far as I can tell, your changes work very well. I confirm your fix.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.