Remove glance-control from the test suite

Bug #1173415 reported by John Bresnahan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
John Bresnahan

Bug Description

As part of the blueprint to make the test suite more robust and the effort to deprecate glance-control we should remove the use of glance control from the test suite.

Changed in glance:
assignee: nobody → John Bresnahan (jbresnah)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27611

Changed in glance:
milestone: none → havana-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/28214

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/27611
Committed: http://github.com/openstack/glance/commit/866cb846f5310e1ad36181e64e7d59ba54d9fd40
Submitter: Jenkins
Branch: master

commit 866cb846f5310e1ad36181e64e7d59ba54d9fd40
Author: John Bresnahan <email address hidden>
Date: Fri May 3 10:50:42 2013 -1000

    Remove glance-control from the test suite

    This patch removes the use of glance-control from the test suite. Instead
    of forking out glance-control and letting it fork out the other programs,
    we will now fork out the other programs directly. The file which tested
    glance-control has also been removed. While we will still have
    glance-control as part of the distribution for a bit and thus it should
    still be tested, that test was doing so in a way that depended upon the
    forking behavior previously found in the test suite.

    This patch also requires the patch
    https://review.openstack.org/#/c/26076/ on which it is dependent. As a
    side effect it tests for the problem found in bug: 1068051

    Additionally, this fixes a race condition. Previously each functional
    test called cleanup() in tearDown(). Cleanup would open a pid file and
    send a SIGTERM to the processes (api, registry, scrubber). However,
    it did not wait for this process to die and get cleaned up. The signal
    handler in the processes is over ridden so the death is not instant.
    This leaves a chance for server from a previous test to be actively
    listening on a port when the next test starts.

    fixes bug: 1173415
    blueprint: refactoring-better-faster-stronger-functional-tests

    Change-Id: Iabdb6fdc13b5f1993590b5a801a0e89df1a544c7

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: added: grizzly-backport-potential
Revision history for this message
Alan Pevec (apevec) wrote :

We're seeing random failures in Glance grizzly jobs[1] and this should help stabilize Glance functional tests.

[1] search for "periodic-glance" on http://lists.openstack.org/pipermail/openstack-stable-maint/2013-August/date.html

Thierry Carrez (ttx)
Changed in glance:
milestone: havana-1 → 2013.2
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.