juju-core

environs/providers must report instance state, like py-juju

Bug #1167441 reported by Dimiter Naydenov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
Andrew Wilkins
juju-core 1.14.0

Bug Description

We have "instance-state" in juju status, which should report a provider-specific instance state for a machine (from the provider point of view, not from juju's).
Unfortunately, we don't have support for that currently, so it needs to be done and affects all providers.

Related branches

lp://staging/~axwalk/goamz/ec2test-instance-state
goamz maintainers: Pending requested
Diff: 11 lines (+1/-0)
1 file modified
ec2/ec2test/server.go (+1/-0)
lp://staging/~axwalk/juju-core/lp1167441-report-instance-state
Juju Engineering: Pending requested
Diff: 299 lines (+96/-7)
15 files modified
cmd/juju/status.go (+1/-0)
container/lxc/instance.go (+10/-0)
container/lxc/lxc.go (+2/-2)
container/lxc/lxc_test.go (+15/-0)
environs/azure/instance.go (+5/-0)
environs/azure/instance_test.go (+8/-0)
environs/dummy/environs.go (+4/-0)
environs/ec2/ec2.go (+4/-0)
environs/ec2/local_test.go (+15/-0)
environs/local/instance.go (+5/-0)
environs/maas/instance.go (+9/-0)
environs/openstack/local_test.go (+8/-0)
environs/openstack/provider.go (+4/-0)
environs/polling_test.go (+3/-5)
instance/instance.go (+3/-0)
Revision history for this message
Dimiter Naydenov (dimitern) wrote :

The support for getting instance status from the underlying libraries already exists, both in goamz and goose. So we need to include InstanceStatus() or something in the environs/interface.go and implement it in the providers.

William Reade (fwereade)
Changed in juju-core:
status: Confirmed → Triaged
assignee: Dimiter Naydenov (dimitern) → nobody
Andrew Wilkins (axwalk)
Changed in juju-core:
assignee: nobody → Andrew Wilkins (axwalk)
Revision history for this message
Andrew Wilkins (axwalk) wrote :

I've made a start on this. I've added a Status method to instance.Instance, and all implementations thereof. The only ones that will return a non-empty string are azure, ec2, openstack, and container/lxc.

I can't see any way of getting a machine status from MAAS. Local is always running, of course, so I'll just leave it as blank (which is omitted by juju status).

Revision history for this message
Andrew Wilkins (axwalk) wrote :

It'll take a bit longer to test than anticipated, as goamz/ec2/ec2test has some needed TODOs.

Andrew Wilkins (axwalk)
Changed in juju-core:
status: Triaged → In Progress
Andrew Wilkins (axwalk)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: none → 1.14.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.