Undoing a headline change does not change focus to the headline.
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| leo-editor |
Fix Released
|
Medium
|
Edward K. Ream | ||
Bug Description
Undoing a headline change does not change focus to the headline and does not open the headline for editing. Hence, if the undo occurs in a headline far from the current focus whether it is on the screen or off the screen, the operator is left wondering, "What did that undo do? Nothing that I could see."
But undoing a body edit does shift focus to the body where the undo occurs and leaves the body open for editing.
Undoing a headline edit should leave the headline in which the undo occurs open for editing. That is what I would expect based on undoing a body edit.
Note: It would be even better if undoing a body edit first shifted focus to the first body line about to changed, then paused for one second, then undid the edit. This would give the operator a hint about what is undone. Similarly a headline undo should shift focus to the headline, pause for one second, then undo the edit.
Test procedure:
Create a new Leo-Editor file by specifying a non-existent file on the command line that starts Leo-Editor.
Example:
leomy redo.leo
Ctrl-i (Creates a second node)
Alt-up-arrow (focus to first node)
Ctrl-h (open first node for edit)
word1 (Resulting headline: redo.leoword1)
Alt-down-arrow (focus to second node)
Ctrl-z (Undoes the edit of first node leaving headline redo.leo)
Focus is still on the second node.
Note that the focus is still on the second node. The undo did not move the focus and did not open the first headline for edit.
-------
I use Xubuntu 12.04 (precise)
Kernel 3.2.0-39-generic
Leo Log Window
Leo 4.11 devel, build 5645, 2013-03-30 09:55:35
Python 2.7.3, qt version 4.8.1
linux2
| Changed in leo-editor: | |
| status: | New → Confirmed |
| Edward K. Ream (edreamleo) wrote Re: [Bug 1162307] [NEW] Undoing a headline change does not change focus to the headline. | #1 |
| Changed in leo-editor: | |
| assignee: | nobody → Edward K. Ream (edreamleo) |
| importance: | Undecided → Medium |
| status: | Confirmed → Fix Released |
| Edward K. Ream (edreamleo) wrote | #2 |
| Changed in leo-editor: | |
| status: | Fix Released → Confirmed |
| milestone: | none → 4.11-b1 |
| SegundoBob (bhossley) wrote | #3 |
| Edward K. Ream (edreamleo) wrote Re: [Bug 1162307] Re: Undoing a headline change does not change focus to the headline. | #4 |
| Edward K. Ream (edreamleo) wrote | #5 |
| Changed in leo-editor: | |
| status: | Confirmed → Fix Released |
| SegundoBob (bhossley) wrote | #6 |
On Sat, Mar 30, 2013 at 1:36 PM, SegundoBob <email address hidden>wrote:
> Public bug reported:
>
> Undoing a headline change does not change focus to the headline and does
> not open the headline for editing
This is actually a worse bug than you are reporting. Alas, I see no real
way to fix it. The problem isn't primarily a focus problem, it is a deep
problem with undo and headlines.
Leo's headline-editing logic is spectacularly fragile and difficult. Every
once in awhile I look at it again. This report may spur me to try again,
but I wouldn't get my hopes up.
Edward