Warnings at compile-time in GCC 4.8
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Low
|
Unassigned |
Bug Description
As some of you might know, GCC 4.8 was released recently (http://
The main change warning-wise seems to be that it warns about -Wunused-
I only skimmed the rest of the warnings, but they seem to mostly be the same as we get in older releases too.
PS. I filed this as a new bug since I consider bug 825957 as fixed when we became warning-free. After bug 1033615 we are no longer warning-free again, though I think it is better to split out the discussion for these warnings. Otherwise we will end up with a gigantic bug report covering everything which has been closed and reopened multiple times as warnings are removed and introduced.
PPS. See bug 1202101 for warnings generated in Visual Studio.
Related branches
- Tino: Approve
- Widelands Developers: Pending requested
-
Diff: 714 lines (+75/-135)32 files modifiedCMakeLists.txt (+29/-2)
src/compile_assert.h (+0/-28)
src/economy/fleet.cc (+1/-1)
src/economy/portdock.cc (+1/-1)
src/graphic/animation_gfx.cc (+1/-1)
src/graphic/render/gamerenderer_gl.cc (+2/-2)
src/graphic/text/rt_render.cc (+1/-1)
src/io/bitinbuffer.h (+1/-3)
src/io/bitoutbuffer.h (+1/-3)
src/io/filesystem/disk_filesystem.cc (+1/-4)
src/log.h (+1/-1)
src/logic/constructionsite.cc (+1/-1)
src/logic/dismantlesite.cc (+1/-1)
src/logic/field.h (+5/-6)
src/logic/game.cc (+2/-2)
src/logic/ship.cc (+2/-2)
src/logic/trainingsite.cc (+2/-0)
src/logic/warehouse.cc (+1/-1)
src/logic/widelands_geometry.h (+1/-3)
src/map_io/widelands_map_buildingdata_data_packet.cc (+4/-4)
src/map_io/widelands_map_exploration_data_packet.cc (+2/-2)
src/minizip/unzip.cc (+0/-8)
src/scripting/pluto.cc (+1/-1)
src/type_check.h (+0/-33)
src/ui_basic/checkbox.cc (+2/-4)
src/ui_basic/listselect.h (+0/-1)
src/ui_basic/table.h (+1/-2)
src/ui_basic/tabpanel.cc (+2/-4)
src/ui_basic/window.cc (+4/-6)
src/vector.h (+0/-2)
src/wlapplication.cc (+4/-2)
src/wui/encyclopedia_window.cc (+1/-3)
Changed in widelands: | |
status: | New → Triaged |
description: | updated |
Changed in widelands: | |
status: | Triaged → Fix Committed |
milestone: | none → build18-rc1 |
I vote for ignoring - c++11 comes with static_assert which replaces this compile time assert. Once we switch (which we will soonish - c++ 11 is adopted at a fast pace) this warning will go away as well.