close decorated window with ESC

Bug #1134672 reported by jmikelf
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Granite
Fix Released
Low
Julien Spautz

Bug Description

I should be able to close the black-themed album tracklist window by pressing ESC like I do for closing white-themed song information window.

Related branches

Doug Lomax (dlomax11)
description: updated
Revision history for this message
Luca Gaulois (luca-gaulois) wrote :

or maybe also by clicking outside of the black window (but still inside of the noise player)?

Revision history for this message
jmikelf (jmikelf) wrote : Re: [Bug 1134672] Re: close album view with ESC

you can already close it by clicking outside, in the whitespace between
albums. I reported this bug because of the consistency of keyboard
shortcuts across apps

2013/2/28 Lukas Groulik <email address hidden>

> or maybe also by clicking outside of the black window (but still inside
> of the noise player)?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1134672
>
> Title:
> close album view with ESC
>
> Status in Noise Audio Player:
> New
>
> Bug description:
> I should be able to close the black-themed album tracklist window by
> pressing ESC like I do for closing white-themed song information
> window.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/noise/+bug/1134672/+subscriptions
>

Cody Garver (codygarver)
Changed in noise:
milestone: none → luna-beta3
importance: Undecided → Low
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote : Re: close album view with ESC

Isn't this something taken care of in Granite's decorated window?

Changed in noise:
status: New → Confirmed
Revision history for this message
Victor Martinez (victored) wrote :

For some unknown reason, the code that listens for "Esc" key presses was added directly to LightWindow instead of its parent more-generic class DecoratedWindow. LightWindow was only supposed to have theming information, and that's it.

This bug has to be fixed in Granite, not in Noise. Just move the code in question from LightWindow.vala into DecoratedWindow.vala :)

Changed in noise:
status: Confirmed → Invalid
Changed in granite:
status: New → Confirmed
Changed in noise:
importance: Low → Undecided
milestone: luna-beta3 → none
Revision history for this message
Danielle Foré (danrabbit) wrote :

Updated the description to reflect Victor's statement

no longer affects: noise
summary: - close album view with ESC
+ close decorated window with ESC
Changed in granite:
status: Confirmed → In Progress
assignee: nobody → Julien Spautz (julien-spautz)
David Gomes (davidgomes)
Changed in granite:
importance: Undecided → Low
David Gomes (davidgomes)
Changed in granite:
status: In Progress → Fix Committed
milestone: none → luna-beta2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.