Add 2 New Email Alert Frequency Flavors: Weekly and Bi-Weekly

Bug #1132888 reported by Nat Katin-Borland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Medium
Tres Seaver

Bug Description

Per our conversation today, please add 2 new email alert frequency flavors: Weekly (1 digest email per week) and Bi-Weekly (1 digest email every 2 weeks). This will give us 5 total options: Never, Immediately, Daily (1 daily digest), Weekly and Bi-Weekly.

Changed in karl3:
milestone: none → m124
Tres Seaver (tseaver)
Changed in karl3:
milestone: m124 → m125
Revision history for this message
Tres Seaver (tseaver) wrote :

I'm going to label the last option "Every two weeks" to avoid the ambiguity.

Changed in karl3:
status: New → In Progress
Revision history for this message
Nat Katin-Borland (nborland) wrote :

That makes sense!

Revision history for this message
Tres Seaver (tseaver) wrote :

I have code checked in for this issue on the
'tseaver-1132888-new_digest_frequencies' branch of the 'karl'
package.

Once deployed, we will need to update the crontab entires to run
extra digest passes, for instance, from the current::

    11 */6 * * * $KARLSERVE digest >> $LOGS/digest.log 2>&1

to::

    11 */6 * * * $KARLSERVE digest daily >> $LOGS/digest.log 2>&1
    * * * * * sun $KARLSERVE digest weekly >> $LOGS/digest.log 2>&1
    * * * * * sun $KARLSERVE digest biweekly >> $LOGS/digest.log 2>&1

It looks as though we need to make changes to the 'karlserve
digest' bit to pass through the frequency, too (it bypasses
the script in the 'karl' packge).

Changed in karl3:
status: In Progress → Fix Committed
Revision history for this message
Tres Seaver (tseaver) wrote :

Note to self:

  Merging this issue's branch with the 'tseaver-1122345-deconflict_profile_pending_alerts'
  branch is going to be messy.

Changed in karl3:
milestone: m125 → m126
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Staging works ok when you use blog posts instead of wiki pages, so Nat is able to test this once the tseaver-1132888-new_digest_frequencies-m125 (or tseaver-1132888-new_digest_frequencies) branch gets merged.

Revision history for this message
Tres Seaver (tseaver) wrote :

On osfkarl10, change crontab for the digest from::

------------ %< -------------------------
11 */6 * * * $KARLSERVE digest >> $LOGS/digest.log 2>&1
------------ %< -------------------------

to:

------------ %< -------------------------
11 */6 * * * $KARLSERVE digest --frequency daily >> $LOGS/digest.log 2>&1
* * * * * sun $KARLSERVE digest weekly >> $LOGS/digest.log 2>&1
* * * * * sun expr `date +\%W` \% 2 > /dev/null || $KARLSERVE digest biweekly >> $LOGS/digest.log 2>&1
------------ %< -------------------------

Also, add the 'BASH_ENV=/etc/bash/bashrc' at the top of each appserver's
crontab.

Revision history for this message
Tres Seaver (tseaver) wrote :

Released with karl 3.108 and pushed to OSF production (including the crontab change).

Changed in karl3:
status: Fix Committed → Fix Released
Revision history for this message
Tres Seaver (tseaver) wrote :

Nat, did you get an unexpected notification for your every-other-week subscription yesterday?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.