improve the implementation of selection resizing
Bug #1122154 reported by
Olivier Tilloy
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webbrowser-app (Ubuntu) |
Invalid
|
Low
|
Unassigned | ||
| webbrowser-app (Ubuntu RTM) |
Invalid
|
Low
|
Unassigned | ||
Bug Description
(see also bug #1122145 that should be fixed as a prerequisite)
The selection functionality in the browser allows the user to resize the selection rectangle by dragging one of the four handles to include additional blocks.
The current implementation is rather naïve, it computes the center of the resized selection, gets the DOM element below this point, and iterates up the DOM tree until it finds the largest ancestor that fits in the selection rectangle.
This is hopefully good enough for the demo (considering the tight deadline), but it should be made smarter afterwards.
This bug report should be used to gather ideas on how to make the feature smarter, and track their implementation.
Revision history for this message
| Olivier Tilloy (osomon) wrote | #1 |
| description: | updated |
| Changed in manhattan: | |
| milestone: | update-1 → none |
| information type: | Proprietary → Public |
| affects: | manhattan → webbrowser-app |
| Changed in webbrowser-app: | |
| importance: | High → Medium |
| assignee: | Olivier Tilloy (osomon) → nobody |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Confirmed |
| Changed in webbrowser-app: | |
| importance: | Medium → Low |
| Changed in webbrowser-app (Ubuntu): | |
| importance: | Undecided → Low |
| Changed in webbrowser-app (Ubuntu RTM): | |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| no longer affects: | webbrowser-app |
| summary: |
- [browser] improve the implementation of selection resizing + improve the implementation of selection resizing |
| tags: | added: selection |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #2 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Confirmed → Invalid |
| Changed in webbrowser-app (Ubuntu RTM): | |
| status: | Confirmed → Invalid |
To post a comment you must log in.
One of the things that I’d like to experiment with is allowing to select two consecutive blocks without necessarily selecting the whole parent block. For instance:
<div id="container">
…
<p id="text1">…</p>
<img id="img1" />
<img id="img2" />
<img id="img3" />
…
</div>
We should allow selecting img1 and img2 together, or any number of consecutive items, without forcing the selection to the container.
In a more complex scenario, we should even allow selecting two (or more) non consecutive items if they are descendants of the same container, and if they can be visually selected as a rectangle.