MySQL patches by Codership

DML on temporary table tries to append keys for provider

Bug #1112514 reported by Seppo Jaakola
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
MySQL patches by Codership
Fix Released
High
Seppo Jaakola
MySQL patches by Codership 5.5.29-23.7.2
5.5
Fix Released
High
Seppo Jaakola
MySQL patches by Codership 5.5.29-23.7.2
Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC
Fix Released
High
Unassigned
Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC 5.5.29-23.7.2

Bug Description

any update/delete/insert for temporary innodb table, will cause call for provider library append_key() call. The appended key values show as memory leak, and will be released only at server shutdown.

Seppo Jaakola (seppo-jaakola)
Changed in codership-mysql:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Seppo Jaakola (seppo-jaakola)
milestone: none → 5.5.29-24.8
Revision history for this message
Mark Rose (markrose) wrote :

The bug is easy to reproduce. Here is a simplified version:

-- create source table and sample data
CREATE TABLE source (id BIGINT, data BIGINT, PRIMARY KEY(id, data), INDEX (data));
INSERT INTO source (id, data) VALUES (1, 1), (2, 2), (3, 2), (4, 2), (5, 3);

-- create temporary table and insert-select into it
CREATE TEMPORARY TABLE temp (id BIGINT, data BIGINT, PRIMARY KEY (id, data));
-- this leaks
INSERT INTO temp (id, data) SELECT id, data FROM source WHERE data = 2;

Changed in percona-xtradb-cluster:
status: New → Confirmed
Revision history for this message
Seppo Jaakola (seppo-jaakola) wrote :

Fix was pushed in wsrep-23 in revision: http://bazaar.launchpad.net/~codership/codership-mysql/5.5-23/revision/3845
The fix avoids provider key append if affected table is temporary.

However, when testing with the fix build, the mysqld memory image keeps on growing after DML operations on temporary table, and these allocations do not seem to be released when the temporary table is dropped. This behavior is only with InnoDB temporary tables, MyISAM temporary tables behave as expected. It may be that InnoDB temporary table implementation has a memory leak problem, here is one potential bug tracker to follow: http://bugs.mysql.com/bug.php?id=67259

Vadim Tkachenko (vadim-tk)
Changed in percona-xtradb-cluster:
milestone: none → 5.5.29-23.7.2
importance: Undecided → High
status: Confirmed → Fix Committed
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

@Seppo,

During this leak that you noticed with InnoDB temporary tables, did you see 'FLUSH TABLES' freeing any memory

I came across a similar bug here https://mariadb.atlassian.net/browse/MDEV-4016 where file handles were being leaked. Was this the case there as well?

Vadim Tkachenko (vadim-tk)
Changed in percona-xtradb-cluster:
status: Fix Committed → Fix Released
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

@Seppo,

 I have reported a separate XtraDB bug here - https://bugs.launchpad.net/percona-server/+bug/1124242 to investigate this from that angle.

Revision history for this message
Alex Yurchenko (ayurchen) wrote :

fix released in 23.7.3

Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

The fix for this issue is causing https://bugs.launchpad.net/percona-xtradb-cluster/+bug/1240098 (check last few comments).

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXC-951

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.