Product Return Canceled
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Odoo Addons (MOVED TO GITHUB) |
Fix Committed
|
Medium
|
OpenERP R&D Addons Team 2 | ||
OpenERP Community Backports (Addons) |
Fix Committed
|
Medium
|
Yann Papouin | ||
6.1 |
Fix Released
|
Medium
|
Yann Papouin |
Bug Description
STEPS To Reproduce :
1. Create Delivery Order With Product A (Example) 1 Unit.
2. Validate DO.
3. But Somehow we need to make Return Product to this DO.
4. Click Return Product.
5. It will make new Incoming Order Return with Product A (1 Unit). Click Cancel Button to cancel this incoming order return (I know this awkward but one of our customer did it)
Result :
Now, we can't create return of that DO anymore. It will show error message "No products to return (only lines in Done state and not fully returned yet can be returned)". But we didn't return it yet. We cancel it.
Expected Result:
Since we cancel our incoming order return of that DO, it should still can create Return Product of that DO.
Proposed Solution:
we dig into code. We found that stock return wizard in stock module (stock/
In function get_return_history, it check history of return but it doesn't check state of return whether it cancel or not.
So we add conditional to check it if not cancel
130: if rec.location_
131: and rec.location_id.id == m.location_
Thanks You
Regards
Andri
Related branches
- Ajay Patel (OpenERP) (community): Approve
- OpenERP Core Team: Pending requested
-
Diff: 11 lines (+1/-1)1 file modifiedstock/wizard/stock_return_picking.py (+1/-1)
- Sandy Carter (http://www.savoirfairelinux.com): Needs Fixing (code review, pep8)
- Yannick Vaucher @ Camptocamp: Approve (code review, no test)
- Holger Brunn (Therp): Approve (code review)
-
Diff: 25 lines (+5/-4)1 file modifiedstock/wizard/stock_return_picking.py (+5/-4)
- OpenERP Core Team: Pending requested
-
Diff: 26 lines (+6/-4)1 file modifiedstock/wizard/stock_return_picking.py (+6/-4)
- Holger Brunn (Therp): Disapprove
- Sandy Carter (http://www.savoirfairelinux.com): Needs Fixing
-
Diff: 26 lines (+6/-4)1 file modifiedstock/wizard/stock_return_picking.py (+6/-4)
Changed in openobject-addons: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
assignee: | nobody → OpenERP R&D Addons Team 2 (openerp-dev-addons2) |
Changed in openobject-addons: | |
status: | Confirmed → Fix Committed |
Changed in ocb-addons: | |
importance: | Undecided → Medium |
status: | New → Fix Committed |
assignee: | nobody → Yann Papouin (yann-papouin) |
Hello,
It has been Fixed https:/ /code.launchpad .net/~openerp- dev/openobject- addons/ trunk-bug- 1104766- hip
Revno: 8518
Revision ID: <email address hidden>
Thanks,
hip