Mir

System compositor input events passed to console (particularly troublesome for Alt+Fn and Alt+Left/Right)

Bug #1102756 reported by Robert Ancell
68
This bug affects 11 people
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Critical
Maarten Lankhorst
Mir 0.0.9
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When using Mir as a system compositor it doesn't set the VT to KD_GRAPHICS mode so all input events are passed to the console.

See original description

Related branches

lp://staging/~mlankhorst/mir/setsid
Daniel van Vugt: Approve
Chris Halse Rogers: Approve
Robert Ancell: Approve
Alexandros Frantzis (community): Needs Information
Alan Griffiths: Abstain
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 217 lines (+97/-4)
4 files modified
src/server/graphics/gbm/gbm_platform.cpp (+10/-0)
src/server/graphics/gbm/linux_virtual_terminal.cpp (+55/-2)
src/server/graphics/gbm/linux_virtual_terminal.h (+5/-0)
tests/unit-tests/graphics/gbm/test_linux_virtual_terminal.cpp (+27/-2)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Lacks context.

Is this addressed by lp:~alan-griffiths/mir/Add-MIR_DISABLE_INPUT-feature?

Revision history for this message
Chris Halse Rogers (raof) wrote :

No. It's also not (exclusively) a Mir bug, but is here to simplify not leaking private stuff.

To bulk this out - in system-compositor land, circa 13.04, we'll be entirely ignoring Mir's input stack and having all the X servers talk directly to the input devices. This means we get a fully functioning, tested, input stack without significant effort, but means that all clients of the system compositor get all the input, all the time.

Thus, we need to get XMir to cooperate with switching - XMir needs to know when it loses system-compositor focus and release the input devices. Then, XMir needs to know when it gains system-compositor focus and to acquire the input devices.

There's also the fact that Mir doesn't set the VT to KD_GRAPHICS mode, so the kernel also handles everything you type (which is why hitting Alt-F4 under Mir will VT switch)

Revision history for this message
Robert Ancell (robert-ancell) wrote :

The VT stuff should be tracked in bug 1102758

description: updated
Daniel van Vugt (vanvugt)
tags: added: vt
Daniel van Vugt (vanvugt)
information type: Proprietary → Public
Robert Ancell (robert-ancell)
Changed in mir:
assignee: nobody → Robert Ancell (robert-ancell)
Revision history for this message
Ubuntu QA Website (ubuntuqa) wrote :

This bug has been reported on the Ubuntu Package testing tracker.

A list of all reports related to this bug can be found here:
http://packages.qa.ubuntu.com/qatracker/reports/bugs/1102756

tags: added: package-qa-testing
Daniel van Vugt (vanvugt)
summary: - System compositor input events passed to console
+ System compositor input events passed to console (particularly
+ troublesome for Alt+Fn and Alt+Left/Right)
Revision history for this message
Mario Rugiero (mrugiero) wrote :

I'll add to the troublesome combinations, I can't use ctrl+shift+u+<code> to print unicode characters.

Daniel van Vugt (vanvugt)
Changed in mir:
importance: High → Critical
Changed in xmir:
status: New → Invalid
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.0.9

Changed in mir:
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.0.8+13.10.20130808.1-0ubuntu1

---------------
mir (0.0.8+13.10.20130808.1-0ubuntu1) saucy; urgency=low

  [ Robert Ancell ]
  * VT switch on alt+ctrl+Fn.
  * Add missing iostream import. This was accidentally removed in
    revision 939. Local builds and CI builds both seem to have treated
    this as a warning; debian package builds as an error. Fixes
    packaging builds.

  [ Robert Carr ]
  * Add an interface by which the shell may be notified of and interfere
    with surface configuration requests.

  [ Alexandros Frantzis ]
  * Bring back revision 931 with a fix for the crash it caused (LP:
    #1209053). (LP: #1209053)
  * examples: Quit the example servers and standalone programs when
    Ctrl+Alt+Backspace is pressed.

  [ Maarten Lankhorst ]
  * Re-introduce console support, and ignore control characters. (LP:
    #1102756, #1195509)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 944
 -- Ubuntu daily release <email address hidden> Thu, 08 Aug 2013 05:03:26 +0000

Changed in mir (Ubuntu):
status: New → Fix Released
Jono Bacon (jonobacon)
tags: added: flavormirbug
Daniel van Vugt (vanvugt)
Changed in mir:
assignee: Robert Ancell (robert-ancell) → Maarten Lankhorst (mlankhorst)
Robert Ancell (robert-ancell)
Changed in mir:
milestone: none → 0.0.9
status: Fix Committed → Fix Released
no longer affects: xmir
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.