Port to new barrier event API
Bug #1097991 reported by
Chris Halse Rogers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Unity |
Fix Released
|
Medium
|
Brandon Schaefer | ||
| unity (Ubuntu) |
Fix Released
|
Medium
|
Brandon Schaefer | ||
| Raring |
Fix Released
|
Medium
|
Brandon Schaefer | ||
Bug Description
The pointer barrier event API we've patched in to libXfixes has moved upstream in Xserver 1.14. However, the API has changed.
The barrier events and pointer release API is now in the input lib, libXi as of version 1.6.99.1 . It should be reasonably easy to port to the new API: Peter Hutterer's blog post¹ describes how to use it. The main differences are that you need to add the barrier event mask to the XI event mask, rather than window event mask, and that it now uses generic events, so you need to allocate the event data before using it and free the event data after using it XGetEventData/
¹: http://
Related branches
lp://staging/~brandontschaefer/unity/move-pointer-barrier-to-xi-1.6.99.1
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Andrea Azzarone (community): Approve
-
Diff: 703 lines (+261/-152)8 files modifiedCMakeLists.txt (+2/-1)
debian/changelog (+4/-3)
debian/control (+1/-0)
launcher/EdgeBarrierController.cpp (+126/-3)
launcher/EdgeBarrierControllerPrivate.h (+9/-0)
launcher/PointerBarrier.cpp (+82/-94)
launcher/PointerBarrier.h (+7/-5)
tests/test_pointer_barrier.cpp (+30/-46)
Revision history for this message
| Bryce Harrington (bryce) wrote | #1 |
| Changed in unity (Ubuntu): | |
| milestone: | none → ubuntu-13.04-beta-1 |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Brandon Schaefer (brandontschaefer) |
| Changed in unity (Ubuntu Raring): | |
| assignee: | nobody → Brandon Schaefer (brandontschaefer) |
| importance: | Undecided → Medium |
| Changed in unity (Ubuntu): | |
| status: | New → In Progress |
| Changed in unity (Ubuntu Raring): | |
| status: | New → In Progress |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → Medium |
| Changed in unity (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in unity (Ubuntu Raring): | |
| status: | In Progress → Fix Committed |
| Changed in unity: | |
| assignee: | nobody → Brandon Schaefer (brandontschaefer) |
| importance: | Undecided → Medium |
| status: | New → Fix Committed |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| Changed in unity (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in unity (Ubuntu Raring): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Plan of record for raring is to ship xserver 1.14, so fixing this is necessary to avoid a regression in Unity when we introduce 1.14.
1.14 is scheduled for March, with rc releases leading up to that. I'd like to see us include a 1.14 rc or git snapshot in early February so we have adequate testing time.