Broken filtering out of InnoDB stats in mysqldumpslow
Bug #1097692 reported by
Laurynas Biveinis
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Server moved to https://jira.percona.com/projects/PS |
Won't Fix
|
Undecided
|
Laurynas Biveinis | ||
| 5.1 |
Fix Released
|
Undecided
|
Laurynas Biveinis | ||
| 5.5 |
Won't Fix
|
Undecided
|
Laurynas Biveinis | ||
| 5.6 |
Won't Fix
|
Undecided
|
Laurynas Biveinis | ||
Bug Description
The regexps that filter out the InnoDB stats do not handle the case of the waiting times happening to be integer values, resulting in sporadic extraneous lines in mysqldumpslow output.
Fix:
--- Percona-
+++ Percona-
@@ -126,9 +126,9 @@
s/^# Filesort: \S+ Filesort_on_disk: \S+ Merge_passes: \S+\n//;
- s/^# InnoDB_IO_r_ops: \d+ InnoDB_IO_r_bytes: \d+ InnoDB_IO_r_wait: \d+\.\d+\n//;
+ s/^# InnoDB_IO_r_ops: \d+ InnoDB_IO_r_bytes: \d+ InnoDB_IO_r_wait: \d+(\.\d+)?\n//;
- s/^# InnoDB_
+ s/^# InnoDB_
s/^# InnoDB_
Related branches
lp://staging/~laurynas-biveinis/percona-server/slow-log-fixes-5.1
- Stewart Smith (community): Approve
-
Diff: 20056 lines (+9597/-9871)52 files modifiedPercona-Server/mysql-test/include/log_cleanup.inc (+1/-0)
Percona-Server/mysql-test/include/log_start.inc (+3/-8)
Percona-Server/mysql-test/include/log_stop.inc (+2/-2)
Percona-Server/mysql-test/include/percona_slow_extended_error_on_quit.inc (+0/-50)
Percona-Server/mysql-test/include/percona_slow_log_verbosity_grep.inc (+26/-0)
Percona-Server/mysql-test/r/percona_bug643149.result (+2/-2)
Percona-Server/mysql-test/r/percona_log_slow_admin_statements.result (+15/-6)
Percona-Server/mysql-test/r/percona_log_slow_filter.result (+0/-15)
Percona-Server/mysql-test/r/percona_log_slow_innodb.result (+42/-0)
Percona-Server/mysql-test/r/percona_log_slow_query_plan.result (+202/-0)
Percona-Server/mysql-test/r/percona_log_slow_query_plan_qc.result (+35/-0)
Percona-Server/mysql-test/r/percona_log_slow_slave_statements-innodb.result (+6/-1)
Percona-Server/mysql-test/r/percona_log_slow_slave_statements.result (+16/-36)
Percona-Server/mysql-test/r/percona_log_slow_sp_statements.result (+20/-19)
Percona-Server/mysql-test/r/percona_log_slow_timestamp_every.result (+13/-39)
Percona-Server/mysql-test/r/percona_log_slow_verbosity.result (+111/-16)
Percona-Server/mysql-test/r/percona_long_query_time.result (+2/-0)
Percona-Server/mysql-test/r/percona_mysqldumpslow.result (+8100/-9094)
Percona-Server/mysql-test/r/percona_slow_extended_error_on_quit.result (+20/-168)
Percona-Server/mysql-test/r/percona_slow_extended_log_error.result (+14/-0)
Percona-Server/mysql-test/r/percona_slow_query_log_microseconds_timestamp.result (+17/-17)
Percona-Server/mysql-test/r/percona_use_global_log_slow_control.result (+2/-0)
Percona-Server/mysql-test/r/percona_use_global_long_query_time.result (+2/-0)
Percona-Server/mysql-test/t/disabled.def (+1/-0)
Percona-Server/mysql-test/t/percona_log_slow_admin_statements.test (+41/-2)
Percona-Server/mysql-test/t/percona_log_slow_filter.test (+0/-26)
Percona-Server/mysql-test/t/percona_log_slow_innodb.test (+82/-0)
Percona-Server/mysql-test/t/percona_log_slow_query_plan.test (+302/-0)
Percona-Server/mysql-test/t/percona_log_slow_query_plan_qc.test (+71/-0)
Percona-Server/mysql-test/t/percona_log_slow_slave_statements-innodb-slave.opt (+0/-1)
Percona-Server/mysql-test/t/percona_log_slow_slave_statements-innodb.test (+16/-16)
Percona-Server/mysql-test/t/percona_log_slow_slave_statements-slave.opt (+0/-1)
Percona-Server/mysql-test/t/percona_log_slow_slave_statements.test (+50/-101)
Percona-Server/mysql-test/t/percona_log_slow_sp_statements.test (+34/-20)
Percona-Server/mysql-test/t/percona_log_slow_timestamp_every.test (+17/-29)
Percona-Server/mysql-test/t/percona_log_slow_verbosity.test (+75/-19)
Percona-Server/mysql-test/t/percona_long_query_time.test (+4/-0)
Percona-Server/mysql-test/t/percona_min_examined_row_limit.test (+1/-0)
Percona-Server/mysql-test/t/percona_mysqldumpslow.test (+59/-24)
Percona-Server/mysql-test/t/percona_slow_extended_error_on_quit.test (+58/-74)
Percona-Server/mysql-test/t/percona_slow_extended_log_error.test (+31/-0)
Percona-Server/mysql-test/t/percona_slow_query_log_microseconds_timestamp.test (+36/-24)
Percona-Server/mysql-test/t/percona_use_global_log_slow_control.test (+4/-1)
Percona-Server/mysql-test/t/percona_use_global_long_query_time.test (+5/-0)
Percona-Server/scripts/mysqldumpslow.sh (+3/-3)
Percona-Server/sql/event_scheduler.cc (+0/-1)
Percona-Server/sql/log.cc (+48/-22)
Percona-Server/sql/log_event.cc (+5/-9)
Percona-Server/sql/slave.cc (+1/-2)
Percona-Server/sql/sql_class.h (+0/-13)
Percona-Server/sql/sql_connect.cc (+0/-9)
Percona-Server/sql/sql_parse.cc (+2/-1)
| tags: | added: slow-extended |
| Changed in percona-server: | |
| status: | In Progress → Won't Fix |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/