TPAC: search returns no results after selecting two facets

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/facetfix

This bug is interesting. I did check on your page, and it really happened as you mentioned.
But you know, it doesn't happen with our libs's page (using Evergreen 2.2)
You can try to reproduce at this: https://campbelld.mnpals.net/eg/opac/home
I bet it will not happen like your page. Whenever you click on Search button, it will search the keyword again and return the result as we expected.
In my opinion, since the search form use the GET method, whenever we click on Search button, it should only send the query URI with elements of search form only without the facets array.
I'm trying to figure out why it has happened in your page. And hopefully somebody can find out the solution soon.

I think I know why you got no result now. The problem is in my attached picture. You can see:
- in your page using Evergreen 2.3, after we select 2 facets, the search form will appear a hidden input as facet (I'm wondering if this is the new feature Evergreen created to keep the selected facets even when you click Search button again, but it's not working well though)
- in our page using Evergreen 2.2, after I select 2 facets, the search form still have no hidden facet input. So the page only search the keyword without selected facets, that's why I got result with no error.
Actually, our libs are happy with this current way of search result. I don't know why you want to insert the hidden facet input into the search form to keep the facet values. In my opinion, whenever you click on the search button, it should start search the keyword again with no selected facets.
I will work on this bug after Xmas holiday. Hopefully we will figure out this bug soon.
(In picture: our page is in the left side)

Hi Simon,

It looks like Dan already has a potential fix with a pullrequest tag for this particular bug report. But you might want to take a look at https://bugs.launchpad.net/evergreen/+bug/1091659, which gets at the whole issue you just raised about not maintaining the facet when launching a new search.

Oh, ok Kathy, I didn't see the Dan's fix before. That's is exactly what I'm thinking about how to fix for this bug.
But actually as I mentioned before, I don't think we should maintain the selected facets when click on a new Search again.
That's the searching way of other products that we've been using as ALEPH, VUFIND, ...

Thanks Dan (and Simon and Kathy!); I've posted a branch that fixes both this problem and bug 1091659 over in bug 1091659 - it takes the approach that the hidden form vars are the root of the problem, as Simon suggests.

Tested and works well for me. Thanks Dan!

Picked to master, rel_2_3, and rel_2_2. I'll note the fix and targets on the related bug as well.