Automatically move Terminal to right side if certain width [$50]
Bug #1085718 reported by
Danielle Foré
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Scratch |
Fix Released
|
Wishlist
|
Artem Anufrij | ||
Bug Description
Once the editor gets to a certain width (not just the window, because we also have to think about the width of the sources list), I feel like the terminal should go to the right side of the window.
I believe our style guidelines say a line shouldn't be longer than 120 chars. So maybe after 150 chars or so, the Terminal should switch over. That way, it's occupying space that is normally blank instead of space I could be using to read code.
Related branches
lp://staging/~artem-anufrij/scratch/Bugfix-1085718
- Raphael Isemann (community): Approve (functionality, code-style)
- Danielle Foré: Approve (ux)
- Artem Anufrij: Pending ((ux)) requested
-
Diff: 264 lines (+86/-23)4 files modifiedplugins/terminal/terminal.vala (+70/-18)
src/MainWindow.vala (+11/-3)
src/Widgets/SplitView.vala (+3/-1)
src/Widgets/ToolBar.vala (+2/-1)
| Changed in scratch: | |
| status: | New → Confirmed |
| milestone: | none → 2.0 |
Revision history for this message
| swizzle (el-ferreira-deactivatedaccount) wrote | #1 |
| Changed in scratch: | |
| milestone: | 2.0.1 → 2.1 |
| Changed in scratch: | |
| milestone: | isis-beta1 → feature-future |
| Changed in scratch: | |
| milestone: | feature-future → isis-beta1 |
| Changed in scratch: | |
| milestone: | isis-beta1 → isis-beta2 |
| Changed in scratch: | |
| milestone: | freya-beta2 → 3.0 |
Revision history for this message
| Danielle Foré (danrabbit) wrote | #2 |
| summary: |
- Automatically move Terminal to right side if certain width + Automatically move Terminal to right side if certain width [$50] |
Revision history for this message
| Danielle Foré (danrabbit) wrote | #3 |
| Changed in scratch: | |
| assignee: | nobody → Jesse Cheun (jcheun93) |
| status: | Confirmed → In Progress |
| Changed in scratch: | |
| assignee: | Jesse Cheun (jcheun93) → Artem Anufrij (artem-anufrij) |
Revision history for this message
| Artem Anufrij (artem-anufrij) wrote | #4 |
Revision history for this message
| Robert Roth (evfool) wrote | #5 |
Revision history for this message
| Artem Anufrij (artem-anufrij) wrote | #6 |
Revision history for this message
| Artem Anufrij (artem-anufrij) wrote | #7 |
| Changed in scratch: | |
| status: | In Progress → Fix Committed |
| milestone: | 3.0 → freya-beta2 |
| Changed in scratch: | |
| status: | Fix Committed → Fix Released |
| Changed in scratch: | |
| milestone: | freya-beta2 → 2.1 |
To post a comment you must log in.
This should only happen when only one view is shown.
Adding a second (or more) view(s) should move the terminal to the bottom.