KPAC - Get it - choose pickup library not working
Bug #1080872 reported by
Ben Shum
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
Evergreen master, 2.3
In Kid's catalog (KPAC), when clicking on "Get it", one is taken to a screen to place a hold on the material. The user has to input their barcode and password and also choose a pickup library to create the hold.
However, the pickup library dropdown is not defined in the interface, the dropdown contains no entries at all. If unselected (which you can't select anything since the dropdown doesn't populate), this leads to an apache 400 "Bad Request" failure.
Looking at the code, I can see that getit.tt2 is still using PROCESS to pass variables, but changing that to INCLUDE does not fix it to add back the dropdown values for pickup library.
Confirmed on our catalog and tested along with MVLC and Conifer's KPAC equivalents.
| Changed in evergreen: | |
| milestone: | none → 2.3.2 |
Revision history for this message
| Ben Shum (bshum) wrote | #1 |
Revision history for this message
| Ben Shum (bshum) wrote | #4 |
| Changed in evergreen: | |
| status: | Confirmed → Fix Committed |
| Changed in evergreen: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
So it does turn out to be bad variable leaks with use of PROCESS instead of INCLUDE.
Instead of
PROCESS get_marc_attrs args=attrs;
it should be:
INCLUDE get_marc_attrs args=attrs;
This change fixes getit.tt2 to allow the pickup library dropdown to populate.
Branch forthcoming.