Give translators more control over toolbar label

Bug #1074115 reported by Sergey "Shnatsel" Davidoff
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Noise
Fix Released
Low
Corentin Noël

Bug Description

Currently the order in which content items appear in "Songname by Artist on Album" label is hardcoded in Noise. I need "Songname on Album by Artist" to avoid using the [apparently unsupported] declensions for artist names, otherwise the label reads very awkward.

Please give translators more control over the order of the content items in the label.

Tags: l10n
tags: added: l10n
Changed in noise:
status: New → Confirmed
Changed in noise:
importance: Undecided → Low
assignee: nobody → Victor Eduardo (victored)
milestone: none → luna-beta1
status: Confirmed → In Progress
Revision history for this message
Corentin Noël (tintou) wrote :

Okay, we will give you this power. But there is no easy function to do that, I recommend to do a string :
_("(title) by (artist) on (album)")
and use the string.replace ("(title)", title_var); function.

If you are aware of something easiest, fell free to say ;)

(I tried the _(@"$(t.title) by $(t.artist)") function but the string is evaluated at compilation time…)

Revision history for this message
Victor Martinez (victored) wrote :

Corentin, this will be implemented by adding a custom syntax; pretty close to your idea. Of course I will add an explanation for translators. For instance:

English: "$NAME by $ARTIST on $ALBUM"
Spanish: "$NAME en $ALBUM por $ARTIST"

Cody Garver (codygarver)
Changed in noise:
milestone: luna-beta1 → luna-beta2
Revision history for this message
Victor Martinez (victored) wrote :

Fixed on rev. 1165. Thanks Corentin.

Changed in noise:
assignee: Victor Eduardo (victored) → Corentin Noël (tintou)
milestone: luna-beta2 → luna-beta1
status: In Progress → Fix Committed
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

There's still an "%s by %s" string, with this comment:
Title format used on Album View Popup: $ALBUM by $ARTIST

Everything else seems to be fine, thanks!

Changed in noise:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.