set default source to something meaningful

IMHO, something usefull would actually be the API enpoint for the keystone that is used to manage identities.

Not sure that's enough if you have multiple region for example, that won't help identifying which region the instance id for example come from.

Just thinking out loud. :)

Can we get something like that out of the notification messages? We'll have an endpoint for polling, but it might be different. Would that matter?

All we have in notifications that looks like that would be "publisher_id", but it's really not that useful and interesting as a source.

I think more at source like the platform your getting data from. Maybe that should simply be a configuration option that is used by the collector and agent to put in their meter messages?
So if you run an agent on 2 different platforms for the same openstack, each one can be configured to be a different source.

That may be the best solution. If we do go that route, we should remove the source field from Counter and make it an argument to the publish function so all of the plugins aren't tied to that config setting.

I agree. I volunteer to make the change if nobody objects.

+1 but would recommend that you bring up the question in the meeting before jumping to the solution, as others may have great ideas :)

+1 on getting other feedback and having Julien do the work.

Ack!

See also #1038043, which I closed as a dupe of this one.