Messaging Menu

Unable to remove icon from menuitem

Bug #1070421 reported by Vsevolod Velichko on 2012-10-23

This bug affects 2 people

	Status	Importance	Assigned to	Milestone
Messaging Menu	Fix Released	Medium	Lars Karlitski	Messaging Menu 12.10.5
qutim	Fix Released	Medium	Vsevolod Velichko
indicator-messages (Ubuntu)	Fix Released	Low	Unassigned
Quantal	Won't Fix	Low	Unassigned

Bug Description

Impact:
It's not possible to remove icons once added

Test Case:
- download the file from comment #4
- Compile with:
gcc reproduce-lp1070421.c -o testcase `pkg-config --cflags --libs messaging-menu`
- "Something happened" will appear below the "Empathy" entry in the messaging menu. Without the fix to this bug, an "icon-not-found" icon will be displayed. With the fix, no icon should appear.

Regression Potential:
Limited, it makes work a case which was broken, if the fix is not correct it would keep not working
---

At the moment if I create some Messaging Menu menuitem with no icon (GIcon *icon = NULL), it is created with no icon, as it is supposed to be.
Then I set some icon with messaging_menu_app_set_source_icon, and later I want to remove it. I call messaging_menu_app_set_source_icon again, providing NULL as pointer to icon, and icon is not removed, but is set to some "icon-not-found" icon (I don't know real name for that icon).
So the only way to remove icon from source is to completely remove it and create again. I suppose that it is a bug.

See original description

Tags:

Related branches

lp://staging/~larsu/indicator-messages/lp1070421

Merged into lp://staging/indicator-messages/13.04 at revision 325

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2012-10-24

Charles Kerr (community): Approve on 2012-10-24

Revision history for this message

Vsevolod Velichko (torkvemada) wrote on 2012-10-23:

Practically you have to call
g_menu_item_set_attribute (menuitem, "x-canonical-type", "s", "ImSourceMenuItem");
in case if icon is null.

Vsevolod Velichko (torkvemada) on 2012-10-23

Changed in qutim:
status:	New → Confirmed
importance:	Undecided → Medium
assignee:	nobody → Vsevolod Velichko (torkvemada)

Revision history for this message

Lars Karlitski (larsu) wrote on 2012-10-24:

Thanks for spotting that bug, Vsevolod. The attached branch fixes it.

Changed in indicator-messages:
status:	New → In Progress
assignee:	nobody → Lars Uebernickel (larsu)
importance:	Undecided → Medium
milestone:	none → 12.10.5

PS Jenkins bot (ps-jenkins) on 2012-10-24

Changed in indicator-messages:
status:	In Progress → Fix Committed

Sebastien Bacher (seb128) on 2012-10-24

Changed in indicator-messages (Ubuntu):
status:	New → In Progress
importance:	Undecided → Low
Changed in indicator-messages (Ubuntu Quantal):
importance:	Undecided → Low
status:	New → In Progress

Lars Karlitski (larsu) on 2012-10-24

Changed in indicator-messages:
status:	Fix Committed → Fix Released

Sebastien Bacher (seb128) on 2012-10-24

description:

updated

Revision history for this message

Steve Langasek (vorlon) wrote on 2012-11-05:

The provided test case is not straightforward for a tester to follow. Please provide a test case that does not rely on knowledge of the indicator APIs.

Revision history for this message

Lars Karlitski (larsu) wrote on 2012-11-05:

reproduce-lp1070421.c Edit (507 bytes, text/plain)

Attached a program that reproduces this issue. Compile with:

cc reproduce-lp1070421.c `pkg-config --cflags --libs messaging-menu`

"Something happened" will appear below the "Empathy" entry in the messaging menu. Without the fix to this bug, an "icon-not-found" icon will be displayed. With the fix, no icon should appear.

Sebastien Bacher (seb128) on 2012-11-05

description:	updated
description:	updated

Revision history for this message

Brian Murray (brian-murray) wrote on 2012-11-29: Please test proposed package

Hello Vsevolod, or anyone else affected,

Accepted indicator-messages into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/indicator-messages/12.10.5-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in indicator-messages (Ubuntu Quantal):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Vsevolod Velichko (torkvemada) on 2012-12-07

tags:	added: verification-done removed: verification-needed
Changed in qutim:
status:	Confirmed → Fix Committed

Sebastien Bacher (seb128) on 2013-10-30

Changed in indicator-messages (Ubuntu):
status:	In Progress → Fix Released

Tretyakov R (roman-i) on 2013-10-31

Changed in qutim:
status:	Fix Committed → Fix Released

Revision history for this message

Rolf Leggewie (r0lf) wrote on 2014-12-05:

quantal has seen the end of its life and is no longer receiving any updates. Marking the quantal task for this ticket as "Won't Fix".

Changed in indicator-messages (Ubuntu Quantal):
status:	Fix Committed → Won't Fix

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

reproduce-lp1070421.c Edit

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.